fix: detect legacy bd split stores in doctor#898
Closed
julianknutsen wants to merge 1 commit intomainfrom
Closed
Conversation
7 tasks
Collaborator
Author
|
Thanks for this contribution, @julianknutsen! Your fix correctly identified that We've merged this via #934, which includes your original commit with your authorship preserved plus maintainer fixups from adoption review. We created a new PR because we needed to add commits but couldn't push directly to your branch. Your commit is in the merged history. We appreciate the contribution and look forward to more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.beads/doltplus.beads/embeddeddoltsplit storesCloses #633
Tests
git diff --checkgo test ./internal/doctor -count=1go test ./cmd/gc -run 'Test(DoDoctorReportsLegacyBDSplitStore|DoctorSkipsDoltChecksTreatsExecGcBeadsBdAsBdContract|DoctorSkipsSuspendedRigChecks|DoltTopologyCheck)' -count=1 -timeout 5mNotes
go test ./cmd/gc -count=1 -timeout 15mwas also tried during validation and hit an existing Dolt lifecycle flake:TestGcBeadsBdEnsureReadyDoesNotRestartAfterTransientTCPProbeFailuresaw launch count2, expected1, then the package timed out whileTestDoltStateRecoverManagedCmdReportsReadOnlyAndRestartswas running.