fix: make hooks sync support non-Claude agents

Make gt hooks sync and gt doctor hooks-sync agent-agnostic. Add SyncForRole, DiscoverRoleLocations, DiscoverWorktrees. Subsume #3074 Gemini-specific code into generic infrastructure.

Co-Authored-By: Jeff Woolley <jrwoolley@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jrwoolley

internal/cmd/hooks_sync.go

@@ -7,6 +7,7 @@ import (
 	"strings"
 
 	"github.com/spf13/cobra"
+	"github.com/steveyegge/gastown/internal/config"
 	"github.com/steveyegge/gastown/internal/hooks"
 	"github.com/steveyegge/gastown/internal/style"
 	"github.com/steveyegge/gastown/internal/workspace"
@@ -16,18 +17,23 @@ var hooksSyncDryRun bool
 
 var hooksSyncCmd = &cobra.Command{
 	Use:   "sync",
-	Short: "Regenerate all .claude/settings.json files",
-	Long: `Regenerate all .claude/settings.json files from the base config and overrides.
+	Short: "Regenerate all agent hook/settings files",
+	Long: `Regenerate hook and settings files for all agents across the workspace.
 
-For each target (mayor, deacon, rig/crew, rig/witness, etc.):
+For Claude agents (settings.json merge):
 1. Load base config
 2. Apply role override (if exists)
 3. Apply rig+role override (if exists)
 4. Merge hooks section into existing settings.json (preserving all fields)
 5. Write updated settings.json
 
+For template-based agents (OpenCode, Gemini, Copilot, etc.):
+1. Resolve the agent configured for each role
+2. Compare deployed hook file against current template
+3. Overwrite if content differs
+
 Examples:
-  gt hooks sync             # Regenerate all settings.json files
+  gt hooks sync             # Regenerate all hook/settings files
   gt hooks sync --dry-run   # Show what would change without writing`,
 	RunE: runHooksSync,
 }
@@ -108,6 +114,84 @@ func runHooksSync(cmd *cobra.Command, args []string) error {
 		}
 	}
 
+	// Sync template-based (non-Claude) agents at each role location.
+	// These agents use SyncForRole (content-aware comparison) instead of the
+	// JSON merge path used for Claude targets above.
+	locations, locErr := hooks.DiscoverRoleLocations(townRoot)
+	if locErr != nil {
+		fmt.Printf("  %s discovering role locations: %v\n", style.Error.Render("✖"), locErr)
+		errors++
+	} else {
+		for _, loc := range locations {
+			rigPath := ""
+			if loc.Rig != "" {
+				rigPath = filepath.Join(townRoot, loc.Rig)
+			}
+			rc := config.ResolveRoleAgentConfig(loc.Role, townRoot, rigPath)
+			if rc == nil || rc.Hooks == nil || rc.Hooks.Provider == "" {
+				continue
+			}
+			// Claude targets are already handled by DiscoverTargets + syncTarget above.
+			if rc.Hooks.Provider == "claude" {
+				continue
+			}
+
+			preset := config.GetAgentPresetByName(rc.Hooks.Provider)
+			useSettingsDir := preset != nil && preset.HooksUseSettingsDir
+
+			// Determine sync targets.
+			// - Town-level roles (mayor, deacon): the role dir IS the working directory.
+			// - Rig roles with useSettingsDir: one shared file in the role parent.
+			// - Rig roles without useSettingsDir (OpenCode, etc.): need files in each
+			//   individual worktree subdirectory.
+			var syncDirs []string
+			if loc.Rig == "" || useSettingsDir {
+				syncDirs = []string{loc.Dir}
+			} else {
+				syncDirs = hooks.DiscoverWorktrees(loc.Dir)
+			}
+
+			for _, dir := range syncDirs {
+				targetPath := filepath.Join(dir, rc.Hooks.Dir, rc.Hooks.SettingsFile)
+				relPath, pathErr := filepath.Rel(townRoot, targetPath)
+				if pathErr != nil {
+					relPath = targetPath
+				}
+
+				if hooksSyncDryRun {
+					if _, statErr := os.Stat(targetPath); statErr == nil {
+						fmt.Printf("  %s %s %s\n", style.Warning.Render("~"), relPath, style.Dim.Render("(would check "+rc.Hooks.Provider+")"))
+					} else {
+						fmt.Printf("  %s %s %s\n", style.Warning.Render("~"), relPath, style.Dim.Render("(would create "+rc.Hooks.Provider+")"))
+						created++
+					}
+					continue
+				}
+
+				result, syncErr := hooks.SyncForRole(rc.Hooks.Provider, dir, dir, loc.Role,
+					rc.Hooks.Dir, rc.Hooks.SettingsFile, useSettingsDir)
+				if syncErr != nil {
+					fmt.Printf("  %s %s (%s): %v\n", style.Error.Render("✖"), relPath, rc.Hooks.Provider, syncErr)
+					errors++
+					failedTargets = append(failedTargets, relPath)
+					continue
+				}
+
+				switch result {
+				case hooks.SyncCreated:
+					fmt.Printf("  %s %s %s\n", style.Success.Render("✓"), relPath, style.Dim.Render("(created "+rc.Hooks.Provider+")"))
+					created++
+				case hooks.SyncUpdated:
+					fmt.Printf("  %s %s %s\n", style.Success.Render("✓"), relPath, style.Dim.Render("(updated "+rc.Hooks.Provider+")"))
+					updated++
+				case hooks.SyncUnchanged:
+					fmt.Printf("  %s %s %s\n", style.Dim.Render("·"), relPath, style.Dim.Render("(unchanged "+rc.Hooks.Provider+")"))
+					unchanged++
+				}
+			}
+		}
+	}
+
 	// Summary
 	fmt.Println()
 	total := updated + unchanged + created + errors

internal/cmd/hooks_sync_test.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/steveyegge/gastown/internal/config"
 	"github.com/steveyegge/gastown/internal/hooks"
 )
 
@@ -297,3 +298,141 @@ func TestRunHooksSyncFailsClosedOnIntegrityViolation(t *testing.T) {
 		t.Fatalf("expected fail-closed error, got: %v", err)
 	}
 }
+
+func TestRunHooksSyncNonClaudeAgent(t *testing.T) {
+	tmpDir := t.TempDir()
+	t.Setenv("HOME", tmpDir)
+
+	townRoot := filepath.Join(tmpDir, "town")
+
+	// Scaffold workspace: mayor, deacon, and a rig with a crew worktree
+	if err := os.MkdirAll(filepath.Join(townRoot, "mayor"), 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.MkdirAll(filepath.Join(townRoot, "deacon"), 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.MkdirAll(filepath.Join(townRoot, "myrig", "crew", "alice"), 0755); err != nil {
+		t.Fatal(err)
+	}
+
+	// Workspace marker
+	if err := os.WriteFile(
+		filepath.Join(townRoot, "mayor", "town.json"),
+		[]byte(`{"type":"town","version":1,"name":"test"}`),
+		0644,
+	); err != nil {
+		t.Fatal(err)
+	}
+
+	// Configure crew role to use opencode
+	townSettings := config.NewTownSettings()
+	townSettings.RoleAgents = map[string]string{"crew": "opencode"}
+	settingsDir := filepath.Join(townRoot, "settings")
+	if err := os.MkdirAll(settingsDir, 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := config.SaveTownSettings(config.TownSettingsPath(townRoot), townSettings); err != nil {
+		t.Fatal(err)
+	}
+
+	// Base hooks config (needed for Claude targets to not error)
+	base := &hooks.HooksConfig{
+		SessionStart: []hooks.HookEntry{
+			{Matcher: "", Hooks: []hooks.Hook{{Type: "command", Command: "echo test"}}},
+		},
+	}
+	if err := hooks.SaveBase(base); err != nil {
+		t.Fatalf("SaveBase failed: %v", err)
+	}
+
+	cwd, err := os.Getwd()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer func() { _ = os.Chdir(cwd) }()
+	if err := os.Chdir(townRoot); err != nil {
+		t.Fatal(err)
+	}
+
+	hooksSyncDryRun = false
+	if err := runHooksSync(nil, nil); err != nil {
+		t.Fatalf("runHooksSync failed: %v", err)
+	}
+
+	// Verify OpenCode plugin was synced to the worktree (not the parent)
+	pluginPath := filepath.Join(townRoot, "myrig", "crew", "alice", ".opencode", "plugins", "gastown.js")
+	if _, err := os.Stat(pluginPath); os.IsNotExist(err) {
+		t.Error("opencode plugin not created in worktree alice")
+	}
+
+	// Verify it was NOT created in the parent (crew/) since useSettingsDir=false
+	parentPlugin := filepath.Join(townRoot, "myrig", "crew", ".opencode", "plugins", "gastown.js")
+	if _, err := os.Stat(parentPlugin); !os.IsNotExist(err) {
+		t.Error("opencode plugin should not be in the parent crew/ directory")
+	}
+}
+
+func TestRunHooksSyncNonClaudeAgentDryRun(t *testing.T) {
+	tmpDir := t.TempDir()
+	t.Setenv("HOME", tmpDir)
+
+	townRoot := filepath.Join(tmpDir, "town")
+
+	if err := os.MkdirAll(filepath.Join(townRoot, "mayor"), 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.MkdirAll(filepath.Join(townRoot, "deacon"), 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.MkdirAll(filepath.Join(townRoot, "myrig", "crew", "alice"), 0755); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := os.WriteFile(
+		filepath.Join(townRoot, "mayor", "town.json"),
+		[]byte(`{"type":"town","version":1,"name":"test"}`),
+		0644,
+	); err != nil {
+		t.Fatal(err)
+	}
+
+	townSettings := config.NewTownSettings()
+	townSettings.RoleAgents = map[string]string{"crew": "opencode"}
+	if err := os.MkdirAll(filepath.Join(townRoot, "settings"), 0755); err != nil {
+		t.Fatal(err)
+	}
+	if err := config.SaveTownSettings(config.TownSettingsPath(townRoot), townSettings); err != nil {
+		t.Fatal(err)
+	}
+
+	base := &hooks.HooksConfig{
+		SessionStart: []hooks.HookEntry{
+			{Matcher: "", Hooks: []hooks.Hook{{Type: "command", Command: "echo test"}}},
+		},
+	}
+	if err := hooks.SaveBase(base); err != nil {
+		t.Fatalf("SaveBase failed: %v", err)
+	}
+
+	cwd, err := os.Getwd()
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer func() { _ = os.Chdir(cwd) }()
+	if err := os.Chdir(townRoot); err != nil {
+		t.Fatal(err)
+	}
+
+	hooksSyncDryRun = true
+	defer func() { hooksSyncDryRun = false }()
+	if err := runHooksSync(nil, nil); err != nil {
+		t.Fatalf("runHooksSync dry-run failed: %v", err)
+	}
+
+	// Dry run should NOT create the file
+	pluginPath := filepath.Join(townRoot, "myrig", "crew", "alice", ".opencode", "plugins", "gastown.js")
+	if _, err := os.Stat(pluginPath); !os.IsNotExist(err) {
+		t.Error("dry-run should not create opencode plugin file")
+	}
+}