Fix all 104 lint issues and install pre-commit hook

- Configure errcheck to exclude fmt.Fprint* (standard for CLIs)
- Fix golangci-lint v2 config format (linters.settings, not linters-settings)
- Add doc comments on all exported methods (revive)
- Rename unused parameters to _ (revive)
- Apply De Morgan's law to hex char checks (staticcheck)
- Fix filepath.Join single-arg call (gocritic)
- Use errors.As instead of type assertion on error (errorlint)
- Remove unused newFakeWLCommonsStore in commons package
- Check errcheck on os.Remove, os.RemoveAll, tmpFile.Close, store.Save

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: julianknutsen

.golangci.yml

@@ -15,10 +15,15 @@ linters:
     - revive
     - unconvert
     - unparam
-
-linters-settings:
-  misspell:
-    locale: US
+  settings:
+    errcheck:
+      # CLI output to stdout/stderr — writes that fail are not recoverable.
+      exclude-functions:
+        - fmt.Fprint
+        - fmt.Fprintf
+        - fmt.Fprintln
+    misspell:
+      locale: US
 
 issues:
   # Show all issues, don't limit per-linter.

cmd/wl/cmd_browse.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"errors"
 	"fmt"
 	"io"
 	"os"
@@ -40,7 +41,7 @@ EXAMPLES:
   wl browse --priority 0             # Critical priority only
   wl browse --limit 5               # Show 5 items
   wl browse --json                   # JSON output`,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return runBrowse(stdout, stderr, project, status, itemType, priority, limit, jsonOut)
 		},
 	}
@@ -55,7 +56,7 @@ EXAMPLES:
 	return cmd
 }
 
-func runBrowse(stdout, stderr io.Writer, project, status, itemType string, priority, limit int, jsonOut bool) error {
+func runBrowse(stdout, _ io.Writer, project, status, itemType string, priority, limit int, jsonOut bool) error {
 	doltPath, err := exec.LookPath("dolt")
 	if err != nil {
 		return fmt.Errorf("dolt not found in PATH — install from https://docs.dolthub.com/introduction/installation")
@@ -65,7 +66,7 @@ func runBrowse(stdout, stderr io.Writer, project, status, itemType string, prior
 	if err != nil {
 		return fmt.Errorf("creating temp directory: %w", err)
 	}
-	defer os.RemoveAll(tmpDir)
+	defer func() { _ = os.RemoveAll(tmpDir) }()
 
 	commonsOrg := "hop"
 	commonsDB := "wl-commons"
@@ -140,7 +141,8 @@ func renderBrowseTable(stdout io.Writer, doltPath, cloneDir, query string) error
 	sqlCmd.Dir = cloneDir
 	output, err := sqlCmd.Output()
 	if err != nil {
-		if exitErr, ok := err.(*exec.ExitError); ok {
+		var exitErr *exec.ExitError
+		if errors.As(err, &exitErr) {
 			return fmt.Errorf("query failed: %s", string(exitErr.Stderr))
 		}
 		return fmt.Errorf("running query: %w", err)

cmd/wl/cmd_claim.go

@@ -33,7 +33,7 @@ Examples:
 	}
 }
 
-func runClaim(cmd *cobra.Command, stdout, stderr io.Writer, wantedID string) error {
+func runClaim(cmd *cobra.Command, stdout, _ io.Writer, wantedID string) error {
 	wlCfg, err := resolveWasteland(cmd)
 	if err != nil {
 		return fmt.Errorf("loading wasteland config: %w", err)

cmd/wl/cmd_done.go

@@ -45,7 +45,7 @@ Examples:
 	return cmd
 }
 
-func runDone(cmd *cobra.Command, stdout, stderr io.Writer, wantedID, evidence string) error {
+func runDone(cmd *cobra.Command, stdout, _ io.Writer, wantedID, evidence string) error {
 	wlCfg, err := resolveWasteland(cmd)
 	if err != nil {
 		return fmt.Errorf("loading wasteland config: %w", err)

cmd/wl/cmd_done_test.go

@@ -19,7 +19,7 @@ func TestGenerateCompletionID_Format(t *testing.T) {
 	}
 	hexPart := id[2:]
 	for _, c := range hexPart {
-		if !((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f')) {
+		if (c < '0' || c > '9') && (c < 'a' || c > 'f') {
 			t.Errorf("generateCompletionID() contains non-hex char %q in %q", string(c), id)
 		}
 	}

cmd/wl/cmd_fake_test.go

@@ -86,7 +86,7 @@ func (f *fakeWLCommonsStore) ClaimWanted(wantedID, rigHandle string) error {
 	return nil
 }
 
-func (f *fakeWLCommonsStore) SubmitCompletion(completionID, wantedID, rigHandle, evidence string) error {
+func (f *fakeWLCommonsStore) SubmitCompletion(_, wantedID, rigHandle, _ string) error {
 	if f.SubmitCompletionErr != nil {
 		return f.SubmitCompletionErr
 	}

cmd/wl/cmd_join.go

@@ -56,7 +56,7 @@ Examples:
   wl join test-org/wl-commons --remote-base /tmp/remotes --fork-org my-fork
   wl join test-org/wl-commons --git-remote /tmp/git-remotes --fork-org my-fork`,
 		Args: cobra.ExactArgs(1),
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			return runJoin(stdout, stderr, args[0], handle, displayName, email, forkOrg, remoteBase, gitRemote)
 		},
 	}

cmd/wl/cmd_leave.go

@@ -36,7 +36,7 @@ Examples:
 	}
 }
 
-func runLeave(cmd *cobra.Command, stdout, stderr io.Writer, positional string) error {
+func runLeave(cmd *cobra.Command, stdout, _ io.Writer, positional string) error {
 	store := federation.NewConfigStore()
 
 	// Determine which upstream to leave: positional arg > --wasteland flag > auto.

cmd/wl/cmd_list.go

@@ -21,7 +21,7 @@ for each wasteland.
 Examples:
   wl list`,
 		Args: cobra.NoArgs,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return runList(stdout, stderr)
 		},
 	}

cmd/wl/cmd_post.go

@@ -37,7 +37,7 @@ Examples:
   wl post --title "Fix auth bug" --project gastown --type bug
   wl post --title "Add federation sync" --type feature --priority 1 --effort large
   wl post --title "Update docs" --tags "docs,federation" --effort small`,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			return runPost(cmd, stdout, stderr, title, description, project, itemType, priority, effort, tags)
 		},
 	}
@@ -55,7 +55,7 @@ Examples:
 	return cmd
 }
 
-func runPost(cmd *cobra.Command, stdout, stderr io.Writer, title, description, project, itemType string, priority int, effort, tags string) error {
+func runPost(cmd *cobra.Command, stdout, _ io.Writer, title, description, project, itemType string, priority int, effort, tags string) error {
 	var tagList []string
 	if tags != "" {
 		for _, t := range strings.Split(tags, ",") {