more tests

Author: gaursagar21

cmd/server/server.go

@@ -622,14 +622,14 @@ func buildUpstreamGraph(def *enginev1.WorkflowDefinition) map[string]map[string]
 // wouldCreateCycle checks whether adding a new dependency edge srcStep → tgtStep
 // (meaning tgtStep would now consume from srcStep) would create a cycle.
 //
-// A cycle exists if srcStep is already reachable from tgtStep through the existing
-// upstream graph — i.e. if tgtStep is already (transitively) upstream of srcStep,
-// then making srcStep upstream of tgtStep closes the loop.
+// A cycle exists if tgtStep is already reachable from srcStep through the existing
+// upstream graph — i.e. if srcStep already transitively depends on tgtStep, then
+// making tgtStep depend on srcStep closes the loop.
 func wouldCreateCycle(upstream map[string]map[string]struct{}, srcStep, tgtStep string) bool {
 	visited := map[string]bool{}
 	var dfs func(n string) bool
 	dfs = func(n string) bool {
-		if n == srcStep {
+		if n == tgtStep {
 			return true
 		}
 		if visited[n] {
@@ -643,7 +643,7 @@ func wouldCreateCycle(upstream map[string]map[string]struct{}, srcStep, tgtStep
 		}
 		return false
 	}
-	return dfs(tgtStep)
+	return dfs(srcStep)
 }
 
 // collectWhenDeps walks a WhenExpr and calls fn for each step_id referenced.