`invalidateFilter` is deprecated in SearchModel.cc

[azeey]

Environment

• OS Version: macOS
• Source or binary build? gz-gui10

Observed in #723

/Users/jenkins/jenkins-agent/workspace/gz_gui-ci-pr_any-homebrew-arm64/gz-gui/src/SearchModel.cc:151:9: warning: 'invalidateFilter' is deprecated: Use begin/endFilterChange() instead [-Wdeprecated-declarations]
  151 |   this->invalidateFilter();
      |         ^
/opt/homebrew/lib/QtCore.framework/Headers/qsortfilterproxymodel.h:127:5: note: 'invalidateFilter' has been explicitly marked deprecated here
  127 |     QT_DEPRECATED_VERSION_X_6_13("Use begin/endFilterChange() instead")
      |     ^
/opt/homebrew/lib/QtCore.framework/Headers/qtdeprecationmarkers.h:245:45: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_13'
  245 | # define QT_DEPRECATED_VERSION_X_6_13(text) QT_DEPRECATED_X(text)
      |                                             ^
/opt/homebrew/lib/QtCore.framework/Headers/qtdeprecationmarkers.h:29:33: note: expanded from macro 'QT_DEPRECATED_X'
   29 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/opt/homebrew/lib/QtCore.framework/Headers/qcompilerdetection.h:1011:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
 1011 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]

[iche033]

I think we're not using the SearchModel class any more? I tried deleting the whole class and noticed that gz-gui and gz-sim built fine. We could suppress the warning and deprecate this class if it's no longer used.

[scpeters]

the function was deprecated in qt 6.10 and will be removed in 6.13 (see invalidateFilter documentation)

the recommendation is to use beginFilterChange (added in qt 6.9) and endFilterChange (added in qt 6.10) instead. We would need ifdefs based on the qt version

I think we're not using the SearchModel class any more? I tried deleting the whole class and noticed that gz-gui and gz-sim built fine. We could suppress the warning and deprecate this class if it's no longer used.

can we remove it from stable releases like Fortress, Harmonic, etc?

[iche033]

Looks like the header is installed so we would need to go through the usual tick-tock cycle to first deprecate the class then remove it later.

[scpeters]

opened a quick PR to suppress the warning in #737

based on the cadence of previous releases (6.7.0 in spring 2024 and 6.9.0 in spring 2025), I'm guessing 6.13.0 will be released in spring 2027, during which time Harmonic and Jetty will still be supported. If we are still supporting a distro with rolling dependency versions (like Homebrew), then we would need to make an additional change to keep the package compiling