handle duplicated TypeDeclaration names in sort, fix #59

Author: gcanti

CHANGELOG.md

@@ -13,6 +13,11 @@
 **Note**: Gaps between patch versions are faulty/broken releases. **Note**: A feature tagged as Experimental is in a
 high state of flux, you're at risk of it changing without notice.
 
+# 0.4.5
+
+- **Bug Fix**
+  - handle duplicated `TypeDeclaration` names in `sort`, fix #59 (@gcanti)
+
 # 0.4.4
 
 - **Bug Fix**

package.json

@@ -1,6 +1,6 @@
 {
   "name": "io-ts-codegen",
-  "version": "0.4.4",
+  "version": "0.4.5",
   "description": "Code generation for io-ts",
   "files": [
     "lib"

src/index.ts

@@ -622,7 +622,11 @@ export const getNodeDependencies = (node: Node): Array<string> => {
 export function getTypeDeclarationGraph(declarations: Array<TypeDeclaration | CustomTypeDeclaration>): Graph {
   const graph: Graph = {}
   declarations.forEach(d => {
-    const vertex = (graph[d.name] = new Vertex(d.name))
+    const name = d.name
+    if (graph.hasOwnProperty(name)) {
+      throw new Error(`duplicated name: ${JSON.stringify(name)}`)
+    }
+    const vertex = (graph[name] = new Vertex(name))
     vertex.afters.push(...getNodeDependencies(d))
   })
   return graph

test/sort.ts

@@ -2,6 +2,19 @@ import * as assert from 'assert'
 import * as t from '../src'
 
 describe('sort', () => {
+  it('should handle duplicate declarations', () => {
+    const declarations: Array<t.TypeDeclaration> = [
+      t.typeDeclaration('A', t.stringType),
+      t.typeDeclaration('A', t.numberType)
+    ]
+    assert.throws(
+      () => {
+        t.sort(declarations)
+      },
+      (e: any) => e.message === 'duplicated name: "A"'
+    )
+  })
+
   it('should handle custom type declarations', () => {
     const declarations = [
       t.typeDeclaration('Person', t.typeCombinator([t.property('id', t.identifier('UserId'))]), true),