Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Commit dc117ba

Browse files
committed
address comments
1 parent 25cefce commit dc117ba

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

docs/user-guide/query/gaffer-syntax/filtering.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ total for all the `added` and `removed` properties.
605605
```python
606606
elements = g_connector.execute_operation(
607607
operation = g.GetElements(
608-
input = [g.EntitySeed(vertex = "John")]
608+
input = [g.EntitySeed(vertex = "John")],
609609
view = g.View(
610610
edges = [
611611
g.ElementDefinition(
@@ -659,7 +659,7 @@ total for all the `added` and `removed` properties.
659659
Elements in Gaffer are often stored in daily time buckets; this allows users to
660660
query a summary of the elements that occurred on a particular day. For example,
661661
a count of the commits John made to the repository on the first of the month. The daily time
662-
buckets are controlled by using the groupBy properties.
662+
buckets are controlled by using the `groupBy` properties.
663663

664664
You can get edges with the same source and destination aggregrated together,
665665
regardless of any dates. This is achieved by overriding the `groupBy` field
@@ -719,7 +719,7 @@ and to instead summarise all elements, e.g. all John committed to repo edges.
719719
```python
720720
elements = g_connector.execute_operation(
721721
operation = g.GetElements(
722-
input = [g.EntitySeed(vertex = "John")]
722+
input = [g.EntitySeed(vertex = "John")],
723723
view = g.View(
724724
edges = [
725725
g.ElementDefinition(
@@ -804,7 +804,7 @@ If you apply some pre-aggregation filtering, you can also select a time window t
804804
```python
805805
elements = g_connector.execute_operation(
806806
operation = g.GetElements(
807-
input = [g.EntitySeed(vertex = "John")]
807+
input = [g.EntitySeed(vertex = "John")],
808808
view = g.View(
809809
edges = [
810810
g.ElementDefinition(
@@ -841,11 +841,11 @@ If you apply some pre-aggregation filtering, you can also select a time window t
841841
There is also a more advanced feature of query-time aggregation which allows you to override
842842
the logic of how Gaffer aggregates properties. For example, by default the count property is aggregated
843843
with Sum, as above, but at query time you can force the count to be aggregated using another operator,
844-
e.g. the Min operator. This would allow you to find things such as the minimum daily count.
844+
e.g. the [Min](../../../reference/binary-operators-guide/koryphe-operators.md#min) operator. This would allow you to find things such as the minimum daily count.
845845
This feature does not affect any of the persisted values and any ingest aggregation that has already
846846
occurred will not be modified.
847847

848-
??? example
848+
!!! example ""
849849

850850
This asks at query time what was the minimum `added` by John on one of his commits
851851
between two dates. This is done by adding an extra 'aggregator' to the operation View.
@@ -911,7 +911,7 @@ occurred will not be modified.
911911
```python
912912
elements = g_connector.execute_operation(
913913
operation = g.GetElements(
914-
input = [g.EntitySeed(vertex = "John")]
914+
input = [g.EntitySeed(vertex = "John")],
915915
view = g.View(
916916
edges = [
917917
g.ElementDefinition(
@@ -945,7 +945,7 @@ occurred will not be modified.
945945
```
946946

947947
More commonly, you will want to set the groupBy to empty for all groups in your schema.
948-
This can be done using the ``globalElements` section in the view:
948+
This can be done using the `globalElements` section in the view:
949949

950950
!!! example ""
951951

@@ -985,7 +985,7 @@ This can be done using the ``globalElements` section in the view:
985985
```python
986986
elements = g_connector.execute_operation(
987987
operation = g.GetElements(
988-
input = [g.EntitySeed(vertex = "John")]
988+
input = [g.EntitySeed(vertex = "John")],
989989
view = g.View(
990990
global_elements = g.GlobalViewElementDefinition(
991991
group_by = []

0 commit comments

Comments
 (0)