gh-4168 Fix size of anno linked event screen

Author: at055612

stroom-core-client/src/main/java/stroom/annotation/client/AnnotationEditPresenter.java

@@ -136,7 +136,7 @@ public AnnotationEditPresenter(final EventBus eventBus,
         this.assignedToPresenter.setDisplayValueFunction(userName -> {
             if (userName != null) {
                 if (!GwtNullSafe.isBlankString(userName.getFullName())) {
-                    return userName.getUserIdentityForAudit() + " ("  + userName.getFullName() + ")";
+                    return userName.getUserIdentityForAudit() + " (" + userName.getFullName() + ")";
                 } else {
                     return userName.getUserIdentityForAudit();
                 }
@@ -927,8 +927,8 @@ public void showLinkedEvents() {
             linkedEventPresenter.edit(annotationDetail.getAnnotation(), refresh -> {
                 if (refresh) {
                     final AnnotationResource annotationResource = GWT.create(AnnotationResource.class);
-                    final Rest<AnnotationDetail> rest = restFactory.create();
-                    rest
+                    restFactory.builder()
+                            .forType(AnnotationDetail.class)
                             .onSuccess(this::updateHistory)
                             .call(annotationResource)
                             .get(annotationDetail.getAnnotation().getId());

stroom-core-client/src/main/java/stroom/annotation/client/LinkedEventPresenter.java

@@ -10,19 +10,17 @@
 import stroom.data.client.presenter.DisplayMode;
 import stroom.data.grid.client.MyDataGrid;
 import stroom.data.grid.client.PagerView;
-import stroom.dispatch.client.Rest;
 import stroom.dispatch.client.RestFactory;
 import stroom.pipeline.shared.SourceLocation;
 import stroom.svg.client.SvgPresets;
+import stroom.util.client.DataGridUtil;
 import stroom.widget.button.client.ButtonView;
 import stroom.widget.popup.client.event.ShowPopupEvent;
 import stroom.widget.popup.client.presenter.PopupSize;
 import stroom.widget.popup.client.presenter.PopupType;
 import stroom.widget.util.client.MultiSelectionModelImpl;
 
-import com.google.gwt.cell.client.TextCell;
 import com.google.gwt.core.client.GWT;
-import com.google.gwt.user.cellview.client.Column;
 import com.google.web.bindery.event.shared.EventBus;
 import com.gwtplatform.mvp.client.MyPresenterWidget;
 import com.gwtplatform.mvp.client.View;
@@ -81,12 +79,11 @@ public LinkedEventPresenter(final EventBus eventBus,
         view.setEventListView(pagerView);
         view.setDataView(dataPresenter.getView());
 
-        dataGrid.addResizableColumn(new Column<EventId, String>(new TextCell()) {
-            @Override
-            public String getValue(final EventId eventId) {
-                return eventId.toString();
-            }
-        }, "Id", ColumnSizeConstants.SMALL_COL);
+        dataGrid.addAutoResizableColumn(
+                DataGridUtil.copyTextColumnBuilder(EventId::toString)
+                        .build(),
+                "Id",
+                ColumnSizeConstants.MEDIUM_COL);
     }
 
     @Override
@@ -99,8 +96,9 @@ protected void onBind() {
                 dirty = true;
 
                 final AnnotationResource annotationResource = GWT.create(AnnotationResource.class);
-                final Rest<List<EventId>> rest = restFactory.create();
-                rest.onSuccess(this::setData)
+                restFactory.builder()
+                        .forListOf(EventId.class)
+                        .onSuccess(this::setData)
                         .call(annotationResource)
                         .link(new EventLink(annotation.getId(), eventId));
             }
@@ -120,8 +118,9 @@ protected void onBind() {
                 }
 
                 final AnnotationResource annotationResource = GWT.create(AnnotationResource.class);
-                final Rest<List<EventId>> rest = restFactory.create();
-                rest.onSuccess(this::setData)
+                restFactory.builder()
+                        .forListOf(EventId.class)
+                        .onSuccess(this::setData)
                         .call(annotationResource)
                         .unlink(new EventLink(annotation.getId(), selected));
             }
@@ -134,14 +133,17 @@ public void edit(final Annotation annotation, final Consumer<Boolean> consumer)
         dirty = false;
 
         final AnnotationResource annotationResource = GWT.create(AnnotationResource.class);
-        final Rest<List<EventId>> rest = restFactory.create();
-        rest.onSuccess(this::show).call(annotationResource).getLinkedEvents(annotation.getId());
+        restFactory.builder()
+                .forListOf(EventId.class)
+                .onSuccess(this::show)
+                .call(annotationResource)
+                .getLinkedEvents(annotation.getId());
     }
 
     private void show(final List<EventId> data) {
         setData(data);
 
-        final PopupSize popupSize = PopupSize.resizable(800, 600);
+        final PopupSize popupSize = PopupSize.resizable(1100, 600);
         ShowPopupEvent.builder(this)
                 .popupType(PopupType.CLOSE_DIALOG)
                 .popupSize(popupSize)
@@ -157,7 +159,7 @@ private void setData(final List<EventId> data) {
         dataGrid.setRowCount(data.size());
 
         // Change the selection if we need to.
-        if (data.size() > 0) {
+        if (!data.isEmpty()) {
             final EventId currentSelection = selectionModel.getSelected();
             if (nextSelection != null && data.contains(nextSelection)) {
                 selectionModel.setSelected(nextSelection);

stroom-core-client/src/main/resources/stroom/annotation/client/LinkedEventViewImpl.ui.xml

@@ -3,12 +3,12 @@
              xmlns:g="urn:import:com.google.gwt.user.client.ui">
     <g:SimplePanel styleName="max default-min-sizes">
         <g:MySplitLayoutPanel styleName="max">
-            <g:west size="250">
+            <g:west size="300">
                 <g:SimplePanel ui:field="eventList" styleName="max stroom-control"/>
             </g:west>
             <g:center>
                 <g:SimplePanel ui:field="data" styleName="max stroom-control"/>
             </g:center>
         </g:MySplitLayoutPanel>
     </g:SimplePanel>
-</ui:UiBinder>
+</ui:UiBinder>

unreleased_changes/20240320_131852_820__4168.md

@@ -0,0 +1,24 @@
+* Issue **#4168** : Increase width of Id column on Annotations Linked Events dialog. Also increase size of dialog and the width of the left hand split pane.
+
+
+```sh
+# ********************************************************************************
+# Issue title: Annotations, Show Linked Events , List of Ids is too small for Medium/Large Fonts
+# Issue link:  https://github.com/gchq/stroom/issues/4168
+# ********************************************************************************
+
+# ONLY the top line will be included as a change entry in the CHANGELOG.
+# The entry should be in GitHub flavour markdown and should be written on a SINGLE
+# line with no hard breaks. You can have multiple change files for a single GitHub issue.
+# The  entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
+# 'Fixed nasty bug'.
+#
+# Examples of acceptable entries are:
+#
+#
+# * Issue **123** : Fix bug with an associated GitHub issue in this repository
+#
+# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
+#
+# * Fix bug with no associated GitHub issue.
+```