Merge pull request #4799 from gchq/gh-4788_selection_handler_deep_copy

#4788 Deep copy selection handlers when duplicating dashboard tables

Author: stroomdev66

Diff for: stroom-core-shared/src/main/java/stroom/dashboard/shared/EmbeddedQueryComponentSettings.java

@@ -27,6 +27,7 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.annotation.JsonPropertyOrder;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
 
@@ -142,8 +143,12 @@ private Builder(final EmbeddedQueryComponentSettings settings) {
             super(settings);
             this.queryRef = settings.queryRef;
             this.showTable = settings.showTable;
-            this.queryTablePreferences = settings.queryTablePreferences;
-            this.selectionFilter = settings.selectionFilter;
+            this.queryTablePreferences = settings.queryTablePreferences == null
+                    ? null
+                    : settings.queryTablePreferences.copy().build();
+            this.selectionFilter = settings.selectionFilter == null
+                    ? null
+                    : new ArrayList<>(settings.selectionFilter);
         }
 
         public Builder queryRef(final DocRef queryRef) {

Diff for: stroom-core-shared/src/main/java/stroom/dashboard/shared/TableComponentSettings.java

@@ -343,7 +343,9 @@ private Builder(final TableComponentSettings tableSettings) {
                     : new ArrayList<>(tableSettings.conditionalFormattingRules);
             this.modelVersion = tableSettings.modelVersion;
             this.applyValueFilters = tableSettings.applyValueFilters;
-            this.selectionFilter = tableSettings.selectionHandlers;
+            this.selectionFilter = tableSettings.selectionHandlers == null
+                    ? null
+                    : new ArrayList<>(tableSettings.selectionHandlers);
         }
 
         private List<ConditionalFormattingRule> copyConditionalFormattingRules(

Diff for: unreleased_changes/20250303_121512_235__4788.md

@@ -0,0 +1,24 @@
+* Issue **#4788** : Deep copy selection handlers when duplicating dashboard tables.
+
+
+```sh
+# ********************************************************************************
+# Issue title: Selection Handlers are not deep copied when a table is duplicated
+# Issue link:  https://github.com/gchq/stroom/issues/4788
+# ********************************************************************************
+
+# ONLY the top line will be included as a change entry in the CHANGELOG.
+# The entry should be in GitHub flavour markdown and should be written on a SINGLE
+# line with no hard breaks. You can have multiple change files for a single GitHub issue.
+# The  entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
+# 'Fixed nasty bug'.
+#
+# Examples of acceptable entries are:
+#
+#
+# * Issue **123** : Fix bug with an associated GitHub issue in this repository
+#
+# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
+#
+# * Fix bug with no associated GitHub issue.
+```