Merge pull request #4197 from gchq/gh-4196-byte-buffer-pool-msg

PR for #4196 - ByteBufferPoolImpl message is incorrect

Author: at055612

stroom-lmdb/src/main/java/stroom/bytebuffer/ByteBufferPoolImpl4.java

@@ -516,7 +516,7 @@ private ByteBuffer createNewBufferIfAllowed(final int offset) {
                         LOGGER.warn("Hit {}% ({}) of the limit of {} for pooled buffers of size {}.",
                                 byteBufferPoolConfigProvider.get().getWarningThresholdPercentage(),
                                 warningThreshold,
-                                newBufferCount,
+                                maxBufferCount,
                                 ModelStringUtil.formatCsv(bufferSizes[offset]));
                     } else if (newBufferCount == maxBufferCount) {
                         LOGGER.warn("Hit limit of {} for pooled buffers of size {}. " +

unreleased_changes/20240410_111120_568__4196.md

@@ -0,0 +1,24 @@
+* Issue **#4196** : Fix warning message when the byte buffer pool hits its threshold.
+
+
+```sh
+# ********************************************************************************
+# Issue title: ByteBufferPoolImpl message is incorrect
+# Issue link:  https://github.com/gchq/stroom/issues/4196
+# ********************************************************************************
+
+# ONLY the top line will be included as a change entry in the CHANGELOG.
+# The entry should be in GitHub flavour markdown and should be written on a SINGLE
+# line with no hard breaks. You can have multiple change files for a single GitHub issue.
+# The  entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
+# 'Fixed nasty bug'.
+#
+# Examples of acceptable entries are:
+#
+#
+# * Issue **123** : Fix bug with an associated GitHub issue in this repository
+#
+# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
+#
+# * Fix bug with no associated GitHub issue.
+```