Merge pull request #4802 from gchq/gh-4758_variable_len_sequence

Gh 4758 variable len sequence

Author: stroomdev66

Diff for: gradle/libs.versions.toml

@@ -13,7 +13,7 @@ elasticsearch = "8.12.2"
 httpcore = "4.4.16" # Transient dependency of Elasticsearch
 flyway = "10.0.0"
 guice = "7.0.0"
-gwt = "2.11.0"
+gwt = "2.12.2"
 jackson-swagger = "2.11.1" # Specific version of jackson for use with the swagger plugin
 jmh = "1.37"
 jooq = "3.18.7" # Defined at the top of this file

Diff for: stroom-analytics/stroom-analytics-impl/src/main/java/stroom/analytics/impl/DuplicateCheckFactoryImpl.java

@@ -20,7 +20,6 @@
 @Singleton
 public class DuplicateCheckFactoryImpl implements DuplicateCheckFactory {
 
-    private final ByteBufferFactory byteBufferFactory;
     private final DuplicateCheckStoreConfig analyticResultStoreConfig;
     private final DuplicateCheckStorePool<String, DuplicateCheckStore> pool;
 
@@ -30,7 +29,6 @@ public DuplicateCheckFactoryImpl(final DuplicateCheckDirs duplicateCheckDirs,
                                      final DuplicateCheckStoreConfig duplicateCheckStoreConfig,
                                      final DuplicateCheckRowSerde duplicateCheckRowSerde,
                                      final Provider<Executor> executorProvider) {
-        this.byteBufferFactory = byteBufferFactory;
         this.analyticResultStoreConfig = duplicateCheckStoreConfig;
 
         pool = new DuplicateCheckStorePool<>(k -> new DuplicateCheckStore(
@@ -84,9 +82,13 @@ public synchronized DuplicateCheckRows fetchData(final FindDuplicateCheckCriteri
     }
 
     public synchronized Boolean delete(final DeleteDuplicateCheckRequest request) {
-        return pool.use(request.getAnalyticDocUuid(), store -> store.delete(request, byteBufferFactory));
+        return pool.use(request.getAnalyticDocUuid(), store -> store.delete(request));
     }
 
+
+    // --------------------------------------------------------------------------------
+
+
     private static class NoOpDuplicateCheck implements DuplicateCheck {
 
         @Override

Diff for: stroom-analytics/stroom-analytics-impl/src/main/java/stroom/analytics/impl/DuplicateCheckRowSerde.java

@@ -17,10 +17,17 @@
 import java.util.Arrays;
 import java.util.List;
 
-class DuplicateCheckRowSerde {
+/**
+ * The serialised key is of the form:
+ * <pre>{@code <hash bytes (8)><seq no bytes(variable)>}</pre>
+ */
+public class DuplicateCheckRowSerde {
 
     private static final LambdaLogger LOGGER = LambdaLoggerFactory.getLogger(DuplicateCheckRowSerde.class);
 
+    private static final int HASH_BYTES = Long.BYTES;
+    private static final int MAX_KEY_BYTES = HASH_BYTES + Long.BYTES;
+
     private final ByteBufferFactory byteBufferFactory;
 
     @Inject
@@ -44,7 +51,7 @@ protected long createHash(final byte[] bytes) {
     private LmdbKV createLmdbKV(final byte[] bytes) {
         // Hash the value.
         final long rowHash = createHash(bytes);
-        final ByteBuffer keyByteBuffer = byteBufferFactory.acquire(Long.BYTES);
+        final ByteBuffer keyByteBuffer = byteBufferFactory.acquire(MAX_KEY_BYTES);
         keyByteBuffer.putLong(rowHash);
         keyByteBuffer.flip();
 
@@ -78,4 +85,8 @@ private byte[] serialise(final List<String> values) {
         }
         return bytes;
     }
+
+    public int getKeyLength() {
+        return HASH_BYTES;
+    }
 }