Fix NPE

Author: stroomdev66

stroom-core-client-widget/src/main/java/stroom/widget/customdatebox/client/DurationPicker.java

@@ -59,7 +59,7 @@ protected void onUnload() {
 
     @Override
     public SimpleDuration getValue() {
-        return new SimpleDuration(time.getValue(), timeUnit.getValue());
+        return SimpleDuration.builder().time(time.getValue()).timeUnit(timeUnit.getValue()).build();
     }
 
     @Override

stroom-core/src/main/java/stroom/core/dataprocess/AbstractProcessorTaskExecutor.java

@@ -139,7 +139,7 @@ public abstract class AbstractProcessorTaskExecutor implements ProcessorTaskExec
     private final InternalStatisticsReceiver internalStatisticsReceiver;
     private final VolumeGroupNameProvider volumeGroupNameProvider;
 
-    private Processor streamProcessor;
+    private Processor processor;
     private ProcessorFilter processorFilter;
     private ProcessorTask processorTask;
     private Source streamSource;
@@ -198,7 +198,7 @@ public ProcessorResult exec(final TaskContext taskContext,
                                 final ProcessorFilter processorFilter,
                                 final ProcessorTask processorTask,
                                 final Source streamSource) {
-        this.streamProcessor = processor;
+        this.processor = processor;
         this.processorFilter = processorFilter;
         this.processorTask = processorTask;
         this.streamSource = streamSource;
@@ -302,8 +302,8 @@ private void process(final TaskContext taskContext) {
             // Set the pipeline so it can be used by a filter if needed.
             pipelineDoc = pipelineStore.readDocument(getProcessDecorator().getPipeline());
             if (pipelineDoc == null) {
-                final String msg = "Pipeline " + streamProcessor.getPipelineUuid()
-                        + " cannot be found for processor with id " + streamProcessor.getId();
+                final String msg = "Pipeline " + processor.getPipelineUuid()
+                        + " cannot be found for processor with id " + processor.getId();
                 LOGGER.error(msg);
                 throw new RuntimeException(msg);
             }
@@ -331,7 +331,7 @@ private void process(final TaskContext taskContext) {
             LOGGER.info(() -> processingInfo);
 
             // Hold the source and feed so the pipeline filters can get them.
-            streamProcessorHolder.setStreamProcessor(streamProcessor, processorTask);
+            streamProcessorHolder.setStreamProcessor(processor, processorTask);
 
             // Process the streams.
             final PipelineData pipelineData = pipelineDataCache.get(pipelineDoc);

stroom-util-shared/src/main/java/stroom/util/shared/time/SimpleDuration.java

@@ -23,7 +23,7 @@ public class SimpleDuration {
     public SimpleDuration(@JsonProperty("time") final long time,
                           @JsonProperty("timeUnit") final TimeUnit timeUnit) {
         this.time = time;
-        this.timeUnit = timeUnit;
+        this.timeUnit = timeUnit == null ? TimeUnit.DAYS : timeUnit;
     }
 
     public long getTime() {
@@ -92,6 +92,9 @@ public Builder timeUnit(final TimeUnit timeUnit) {
         }
 
         public SimpleDuration build() {
+            if (timeUnit == null) {
+                timeUnit = TimeUnit.DAYS;
+            }
             return new SimpleDuration(time, timeUnit);
         }
     }

stroom-util/src/main/java/stroom/util/time/SimpleDurationUtil.java

@@ -38,7 +38,7 @@ public static SimpleDuration parse(final String string) throws ParseException {
                     default -> throw new ParseException("Time unit is invalid: " + trimmed, 0);
                 };
 
-                return new SimpleDuration(time, timeUnit);
+                return SimpleDuration.builder().time(time).timeUnit(timeUnit).build();
             } catch (final RuntimeException e) {
                 throw new ParseException("Format of duration string is invalid: " + trimmed, 0);
             }