Review comments

Author: maiatoday

app/src/main/java/de/berlindroid/zepatch/ui/BitmapToStitches.kt

@@ -29,6 +29,7 @@ import androidx.compose.ui.graphics.asAndroidBitmap
 import androidx.compose.ui.graphics.asImageBitmap
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.painterResource
+import androidx.compose.ui.tooling.preview.Preview
 import androidx.core.graphics.scale
 import de.berlindroid.zepatch.stiches.StitchToPES
 import de.berlindroid.zepatch.stiches.StitchToPES.createEmbroideryFromBitmap
@@ -162,21 +163,10 @@ private fun savePesAfterSelection(context: Context, result: ActivityResult, byte
     }
 }
 
-//@Preview(showBackground = true)
-//@Composable
-//private fun BitmapToStitchesPreview() {
-//    BitmapToStitches(Modifier, "Demo") {
-//        Box(
-//            modifier = Modifier
-//                .fillMaxWidth()
-//                .background(Color.Blue)
-//        ) {
-//            Text(
-//                "Preview Content",
-//                modifier = Modifier.padding(16.dp),
-//                color = Color.White
-//            )
-//        }
-//    }
-//}
+@Preview
+@Composable
+fun BitmapToStitchesPreview() {
+    val imageBitmap = ImageBitmap(width = 100, height = 100) // Replace with a real ImageBitmap if needed
+    BitmapToStitches(reducedImageBitmap = imageBitmap, name = "MyPatch")
+}
 

app/src/main/java/de/berlindroid/zepatch/ui/PatchableToBitmap.kt

@@ -26,20 +26,20 @@ fun PatchableToBitmap(
     patchable: @Composable () -> Unit,
 ) {
     var image by remember { mutableStateOf<ImageBitmap?>(null) }
-    var capture by remember { mutableStateOf(false) }
+    var shouldCapture by remember { mutableStateOf(false) }
 
     Column(modifier = modifier.fillMaxWidth()) {
         Button(onClick = {
             image = null
-            capture = true
+            shouldCapture = true
         }) { Text("Do it") }
         // Compose the content through the composable utility; it will invoke the callback when ready.
         CaptureToBitmap(
             modifier = Modifier.fillMaxWidth(),
-            capture = capture,
+            shouldCapture = shouldCapture,
             onBitmap = { img ->
                 image = img
-                capture = false
+                shouldCapture = false
             },
             content = patchable
         )

app/src/main/java/de/berlindroid/zepatch/ui/PatchableToReducedBitmap.kt

@@ -23,6 +23,7 @@ import androidx.compose.ui.text.input.ImeAction
 import androidx.compose.ui.text.input.KeyboardType
 import androidx.core.graphics.scale
 import androidx.core.text.isDigitsOnly
+import androidx.compose.ui.tooling.preview.Preview
 import com.embroidermodder.punching.reduceColors
 import kotlinx.coroutines.launch
 
@@ -88,10 +89,15 @@ fun PatchableToReducedBitmap(
     }
 }
 
+@Preview
+@Composable
+fun PatchableToReducedBitmapPreview() {
+    PatchableToReducedBitmap(
+        image = ImageBitmap(width = 100, height = 100), // Example ImageBitmap
+        colorCount = 5,
+        onReducedBitmap = {},
+        onColorCountChanged = {}
+    )
+}
+
 
-//@Preview(showBackground = true)
-//@Composable
-//private fun PatchableToReducedBitmapPreview() {
-//    PatchableToReducedBitmap()
-//
-//}

app/src/main/java/de/berlindroid/zepatch/utils/CaptureToBitmap.kt

@@ -1,15 +1,10 @@
 package de.berlindroid.zepatch.utils
 
 import androidx.compose.foundation.background
-import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Box
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
 import androidx.compose.runtime.rememberCoroutineScope
-import androidx.compose.runtime.setValue
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.drawWithContent
 import androidx.compose.ui.graphics.Color
@@ -23,7 +18,7 @@ import kotlinx.coroutines.launch
  * from the rendered UI content.
  *
  * @param modifier A [Modifier] instance to apply to this composable for layout or styling configurations.
- * @param capture A flag to trigger the capture process when set to `true`. The content will be converted
+ * @param shouldCapture A flag to trigger the capture process when set to `true`. The content will be converted
  *                to a bitmap and passed to the `onBitmap` callback.
  * @param onBitmap A callback triggered with the generated [ImageBitmap] once the content has been
  *                 successfully captured.
@@ -33,7 +28,7 @@ import kotlinx.coroutines.launch
 @Composable
 fun CaptureToBitmap(
     modifier: Modifier = Modifier,
-    capture: Boolean = false,
+    shouldCapture: Boolean = false,
     onBitmap: (ImageBitmap) -> Unit,
     content: @Composable () -> Unit,
 ) {
@@ -49,8 +44,8 @@ fun CaptureToBitmap(
             }
             .background(Color.Transparent)
     ) {
-        LaunchedEffect(capture) {
-            if (capture) {
+        LaunchedEffect(shouldCapture) {
+            if (shouldCapture) {
                 coroutineScope.launch {
                     val bitmap = graphicsLayer.toImageBitmap()
                     onBitmap(bitmap)