Skip to content

Commit 5cda226

Browse files
committed
Don't join cargo flags
1 parent 0fa0598 commit 5cda226

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

substrate/utils/wasm-builder/src/builder.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ impl WasmBuilder {
276276
target,
277277
file_path,
278278
self.project_cargo_toml,
279-
self.cargo_flags.join(" "),
279+
self.cargo_flags,
280280
self.rust_flags.join(" "),
281281
self.features_to_enable,
282282
self.file_name,
@@ -353,7 +353,7 @@ fn build_project(
353353
target: RuntimeTarget,
354354
file_name: PathBuf,
355355
project_cargo_toml: PathBuf,
356-
default_cargo_flags: String,
356+
default_cargo_flags: Vec<String>,
357357
default_rustflags: String,
358358
features_to_enable: Vec<String>,
359359
wasm_binary_name: Option<String>,

substrate/utils/wasm-builder/src/wasm_project.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ fn crate_metadata(cargo_manifest: &Path) -> Metadata {
117117
pub(crate) fn create_and_compile(
118118
target: RuntimeTarget,
119119
orig_project_cargo_toml: &Path,
120-
default_cargo_flags: &str,
120+
default_cargo_flags: &[String],
121121
default_rustflags: &str,
122122
cargo_cmd: CargoCommandVersioned,
123123
features_to_enable: Vec<String>,
@@ -832,7 +832,7 @@ fn build_bloaty_blob(
832832
target: RuntimeTarget,
833833
blob_build_profile: &Profile,
834834
project: &Path,
835-
default_cargo_flags: &str,
835+
default_cargo_flags: &[String],
836836
default_rustflags: &str,
837837
cargo_cmd: CargoCommandVersioned,
838838
#[cfg(feature = "metadata-hash")] metadata_hash: Option<[u8; 32]>,
@@ -874,7 +874,7 @@ fn build_bloaty_blob(
874874
.arg("rustc")
875875
.arg(format!("--target={}", target.rustc_target(&cargo_cmd)))
876876
.arg(format!("--manifest-path={}", manifest_path.display()))
877-
.arg(default_cargo_flags)
877+
.args(default_cargo_flags)
878878
.env("RUSTFLAGS", rustflags)
879879
// Manually set the `CARGO_TARGET_DIR` to prevent a cargo deadlock (cargo locks a target dir
880880
// exclusive). The runner project is created in `CARGO_TARGET_DIR` and executing it will

0 commit comments

Comments
 (0)