Skip to content

Commit 53d8fd8

Browse files
committed
Drop build number from Settings About line
Show "0.1.4 · 48979d9" instead of "0.1.4 — 32 · 48979d9". The monotonic build count duplicates the commit identifier visually and just adds noise for end users. CFBundleVersion is still stamped into Info.plist — macOS needs it for update bookkeeping — but it's no longer surfaced in the UI. The "— {build}" form is kept as a fallback for dev builds that happen to be built without git metadata.
1 parent 48979d9 commit 53d8fd8

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,11 @@ Releases are fully automated. The pipeline:
195195

196196
Versioning: `CFBundleShortVersionString` is derived from `git describe`
197197
(post-build script in `project.yml`) — `0.1.0` on a tag, `0.1.0+N` past it.
198-
`CFBundleVersion` is `git rev-list --count HEAD` (monotonic). `GitCommit`
198+
`CFBundleVersion` is `git rev-list --count HEAD` (monotonic, kept for
199+
macOS update bookkeeping even though it isn't shown in UI). `GitCommit`
199200
holds the short SHA (with a `-dirty` suffix when the working tree has
200-
uncommitted changes). Settings → About displays them as
201-
`0.1.0 (17 · 19d5410)`.
201+
uncommitted changes). Settings → About displays marketing version and
202+
commit, e.g. `0.1.0 · 19d5410`.
202203

203204
## Troubleshooting
204205

Sources/Views/SettingsView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ struct SettingsView: View {
120120
let dev = (info["IsDevBuild"] as? String).flatMap { $0.isEmpty ? nil : $0 }
121121
var head = short
122122
if let dev { head += " (\(dev))" }
123-
if let commit, commit != build {
124-
return "\(head) \(build) · \(commit)"
123+
if let commit {
124+
return "\(head) · \(commit)"
125125
}
126126
return "\(head)\(build)"
127127
}

0 commit comments

Comments
 (0)