Fix connection leak in edgeql-go (#394)

Fixes #387

Query introspection code paths were not returning connections to the
pool. If there were more queries than available connections (100 by
default) the generator would block indefinitely after using each
connection once.

Author: fmoor

cmd/edgeql-go/endtoend_test.go

@@ -73,6 +73,13 @@ var tests = []struct {
 		directory:   "testdata/rawmessage",
 		args:        []string{"-rawmessage"},
 	},
+	{
+		// in response to https://github.com/geldata/gel-go/issues/387 which
+		// was caused by a connection leak in introspection functions.
+		description: "generate lots and lots of queries",
+		directory:   "testdata/manyqueries",
+		args:        []string{},
+	},
 }
 
 func TestMain(m *testing.M) {

cmd/edgeql-go/testdata/manyqueries/test-project/edgedb.toml

@@ -0,0 +1,16 @@
+module test
+
+go 1.19
+
+require github.com/geldata/gel-go v1.1.0
+
+require (
+	github.com/certifi/gocertifi v0.0.0-20210507211836-431795d63e8d // indirect
+	github.com/sigurn/crc16 v0.0.0-20211026045750-20ab5afb07e3 // indirect
+	github.com/xdg/scram v1.0.5 // indirect
+	github.com/xdg/stringprep v1.0.3 // indirect
+	golang.org/x/crypto v0.32.0 // indirect
+	golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea // indirect
+	golang.org/x/sys v0.29.0 // indirect
+	golang.org/x/text v0.21.0 // indirect
+)

cmd/edgeql-go/testdata/manyqueries/test-project/go.mod

@@ -0,0 +1,22 @@
+github.com/certifi/gocertifi v0.0.0-20210507211836-431795d63e8d h1:S2NE3iHSwP0XV47EEXL8mWmRdEfGscSJ+7EgePNgt0s=
+github.com/certifi/gocertifi v0.0.0-20210507211836-431795d63e8d/go.mod h1:sGbDF6GwGcLpkNXPUTkMRoywsNa/ol15pxFe6ERfguA=
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/geldata/gel-go v1.1.0 h1:f8Bp9VQbLlcbh4Ip47fxCjFYv0IGXhk5M13uwi3T0P8=
+github.com/geldata/gel-go v1.1.0/go.mod h1:1B2DC889nDzTO7ycWNIARTAEAs9G9PdKBvYrMNv4kHI=
+github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
+github.com/sigurn/crc16 v0.0.0-20211026045750-20ab5afb07e3 h1:aQKxg3+2p+IFXXg97McgDGT5zcMrQoi0EICZs8Pgchs=
+github.com/sigurn/crc16 v0.0.0-20211026045750-20ab5afb07e3/go.mod h1:9/etS5gpQq9BJsJMWg1wpLbfuSnkm8dPF6FdW2JXVhA=
+github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
+github.com/xdg/scram v1.0.5 h1:TuS0RFmt5Is5qm9Tm2SoD89OPqe4IRiFtyFY4iwWXsw=
+github.com/xdg/scram v1.0.5/go.mod h1:lB8K/P019DLNhemzwFU4jHLhdvlE6uDZjXFejJXr49I=
+github.com/xdg/stringprep v1.0.3 h1:cmL5Enob4W83ti/ZHuZLuKD/xqJfus4fVPwE+/BDm+4=
+github.com/xdg/stringprep v1.0.3/go.mod h1:Jhud4/sHMO4oL310DaZAKk9ZaJ08SJfe+sJh0HrGL1Y=
+golang.org/x/crypto v0.32.0 h1:euUpcYgM8WcP71gNpTqQCn6rC2t6ULUPiOzfWaXVVfc=
+golang.org/x/crypto v0.32.0/go.mod h1:ZnnJkOaASj8g0AjIduWNlq2NRxL0PlBrbKVyZ6V/Ugc=
+golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea h1:vLCWI/yYrdEHyN2JzIzPO3aaQJHQdp89IZBA/+azVC4=
+golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea/go.mod h1:V1LtkGg67GoY2N1AnLN78QLrzxkLyJw7RJb1gzOOz9w=
+golang.org/x/sys v0.29.0 h1:TPYlXGxvx1MGTn2GiZDhnjPA9wZzZeGKHHmKhHYvgaU=
+golang.org/x/sys v0.29.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
+golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
+gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

cmd/edgeql-go/testdata/manyqueries/test-project/go.sum

@@ -0,0 +1,10 @@
+package main
+
+import (
+	"github.com/geldata/gel-go"
+	"github.com/geldata/gel-go/gelcfg"
+)
+
+func main() {
+	_, _ = gel.CreateClient(gelcfg.Options{})
+}

cmd/edgeql-go/testdata/manyqueries/test-project/ignore.go

@@ -0,0 +1 @@
+select 1;

cmd/edgeql-go/testdata/manyqueries/test-project/queries/aaxkcdlafformjbpqrlkttlulbysragb.edgeql

@@ -0,0 +1,53 @@
+// Code generated by github.com/geldata/gel-go/cmd/edgeql-go DO NOT EDIT.
+
+package queries
+
+import (
+	"context"
+	_ "embed"
+
+	"github.com/geldata/gel-go/geltypes"
+)
+
+//go:embed aaxkcdlafformjbpqrlkttlulbysragb.edgeql
+var aaxkcdlafformjbpqrlkttlulbysragbCmd string
+
+// aaxkcdlafformjbpqrlkttlulbysragb
+// runs the query found in
+// aaxkcdlafformjbpqrlkttlulbysragb.edgeql
+func aaxkcdlafformjbpqrlkttlulbysragb(
+	ctx context.Context,
+	client geltypes.Executor,
+) (int64, error) {
+	var result int64
+
+	err := client.QuerySingle(
+		ctx,
+		aaxkcdlafformjbpqrlkttlulbysragbCmd,
+		&result,
+	)
+
+	return result, err
+}
+
+// aaxkcdlafformjbpqrlkttlulbysragbJSON
+// runs the query found in
+// aaxkcdlafformjbpqrlkttlulbysragb.edgeql
+// returning the results as json encoded bytes
+func aaxkcdlafformjbpqrlkttlulbysragbJSON(
+	ctx context.Context,
+	client geltypes.Executor,
+) ([]byte, error) {
+	var result []byte
+
+	err := client.QuerySingleJSON(
+		ctx,
+		aaxkcdlafformjbpqrlkttlulbysragbCmd,
+		&result,
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return result, nil
+}

cmd/edgeql-go/testdata/manyqueries/test-project/queries/aaxkcdlafformjbpqrlkttlulbysragb_edgeql.go.assert

@@ -0,0 +1 @@
+select 1;

cmd/edgeql-go/testdata/manyqueries/test-project/queries/abzdvfqqiwyzhmnetiukywybrcyaztoy.edgeql

@@ -0,0 +1,53 @@
+// Code generated by github.com/geldata/gel-go/cmd/edgeql-go DO NOT EDIT.
+
+package queries
+
+import (
+	"context"
+	_ "embed"
+
+	"github.com/geldata/gel-go/geltypes"
+)
+
+//go:embed abzdvfqqiwyzhmnetiukywybrcyaztoy.edgeql
+var abzdvfqqiwyzhmnetiukywybrcyaztoyCmd string
+
+// abzdvfqqiwyzhmnetiukywybrcyaztoy
+// runs the query found in
+// abzdvfqqiwyzhmnetiukywybrcyaztoy.edgeql
+func abzdvfqqiwyzhmnetiukywybrcyaztoy(
+	ctx context.Context,
+	client geltypes.Executor,
+) (int64, error) {
+	var result int64
+
+	err := client.QuerySingle(
+		ctx,
+		abzdvfqqiwyzhmnetiukywybrcyaztoyCmd,
+		&result,
+	)
+
+	return result, err
+}
+
+// abzdvfqqiwyzhmnetiukywybrcyaztoyJSON
+// runs the query found in
+// abzdvfqqiwyzhmnetiukywybrcyaztoy.edgeql
+// returning the results as json encoded bytes
+func abzdvfqqiwyzhmnetiukywybrcyaztoyJSON(
+	ctx context.Context,
+	client geltypes.Executor,
+) ([]byte, error) {
+	var result []byte
+
+	err := client.QuerySingleJSON(
+		ctx,
+		abzdvfqqiwyzhmnetiukywybrcyaztoyCmd,
+		&result,
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return result, nil
+}

cmd/edgeql-go/testdata/manyqueries/test-project/queries/abzdvfqqiwyzhmnetiukywybrcyaztoy_edgeql.go.assert

@@ -0,0 +1 @@
+select 1;