gel-auth: fix client error message (#527)

fantix · mmastrac · web-flow · commit 7458a63c0621 · 2025-08-09T09:27:29.000-05:00
Cherry-pick from geldata/gel#8231 Co-authored-by: Matt Mastracci <matthew@mastracci.com>
diff --git a/gel-auth/src/postgres/client_state_machine.rs b/gel-auth/src/postgres/client_state_machine.rs
@@ -331,9 +331,8 @@ impl ConnectionState {
                     },
                 });
             }
-            (Ready, _) | (Error, _) => {
-                return Err(invalid_state!("Unexpected drive for Ready or Error state"))
-            }
+            (Ready, _) => return Err(invalid_state!("Unexpected drive for Ready state")),
+            (Error, _) => return Err(invalid_state!("Unexpected drive for Error state")),
             _ => return Err(invalid_state!("Unexpected (state, drive) combination")),
         }
         Ok(())

Original file line number	Diff line number	Diff line change
`@@ -331,9 +331,8 @@ impl ConnectionState {`
`331`	`331`	`},`
`332`	`332`	`});`
`333`	`333`	`}`
`334`		`- (Ready, _) \| (Error, _) => {`
`335`		`- return Err(invalid_state!("Unexpected drive for Ready or Error state"))`
`336`		`- }`
	`334`	`+ (Ready, _) => return Err(invalid_state!("Unexpected drive for Ready state")),`
	`335`	`+ (Error, _) => return Err(invalid_state!("Unexpected drive for Error state")),`
`337`	`336`	`_ => return Err(invalid_state!("Unexpected (state, drive) combination")),`
`338`	`337`	`}`
`339`	`338`	`Ok(())`