GOATS-980: Refactor source profile to better handle unsupported types. (#485)

- Make sedProfileTypeSelect optional in SourceProfileSerializer.
- Update format_gpp to return None if sedProfileTypeSelect is not provided.
- Add test to ensure invalid sedProfileTypeSelect values are rejected.
- Add CSS class for smaller accordion body with overflow.
- Adjust SourceProfileEditor to handle null sedType gracefully.
- Display warning with accordion for unsupported source profile types in the UI.

Author: davner

docs/changes/485.change.rst

@@ -0,0 +1 @@
+Refactored Source Profile to handle unsupported profiles and SEDs, and clean up SED rendering logic. Users can now view raw data for unsupported types.

src/goats_tom/serializers/gpp/source_profile/source_profile.py

@@ -28,7 +28,10 @@ class SourceProfileType(str, Enum):
 
 class SourceProfileSerializer(_BaseGPPSerializer):
     sedProfileTypeSelect = serializers.ChoiceField(
-        choices=[e.value for e in SourceProfileType], required=True, allow_blank=False
+        choices=[e.value for e in SourceProfileType],
+        required=False,
+        allow_blank=False,
+        allow_null=True,
     )
     sedTypeSelect = serializers.ChoiceField(
         choices=[e.value for e in SEDType],
@@ -80,7 +83,11 @@ def format_gpp(self) -> dict[str, Any] | None:
         dict[str, Any] | None
             The formatted source profile data, or ``None`` if no data was provided.
         """
-        profile_type = self.validated_data["sedProfileTypeSelect"]
+        profile_type = self.validated_data.get("sedProfileTypeSelect")
+        if not profile_type:
+            # Nothing to format.
+            return None
+
         band_normalized: dict[str, Any] = {}
 
         if self.sed is not None:

src/goats_tom/static/css/cores/halfmoon.goats.css

@@ -482,6 +482,11 @@ select.form-control[multiple] {
   overflow-y: auto;
 }
 
+.accordion-body-sm-overflow {
+  max-height: 250px;
+  overflow-y: auto;
+}
+
 .custom-tooltip {
   overflow-y: auto;
   max-height: 400px;

src/goats_tom/static/js/gpp/fields.js

@@ -181,7 +181,7 @@ const SHARED_FIELDS = [
   },
   // Source profile section.
   {
-    path: "targetEnvironment.firstScienceTarget.sourceProfile.point.bandNormalized.sed",
+    path: "targetEnvironment.firstScienceTarget.sourceProfile",
     handler: "handleSourceProfile",
   },
   // Brightnesses section.

src/goats_tom/static/js/gpp/observation_form.js

@@ -91,7 +91,7 @@ class ObservationForm {
         const div = Utils.createElement("div", "mt-3");
         new SourceProfileEditor(div, {
           data: raw ?? {},
-          readOnly: this.#readOnly,
+          debug: true,
         });
         return [div];
       },

src/goats_tom/static/js/gpp/program_observations_panel.js

@@ -79,7 +79,7 @@ class ProgramObservationsPanel {
    */
   setDebug(flag) {
     this.#debug = flag;
-    this.#logDebug("Debug logging enabled.");
+    this.#logDebug(`Setting debug to ${flag}`);
   }
 
   /**