GOATS-845 GOATS-723: Add GPP program ID field and GPP URL generation for GEM observations. (#488)

- Introduced `gpp_program_id` field in `GEMObservationForm`.
- Updated `observationrecord_detail.html` to use `gpp_url` for the GEM facility.
- Implemented GPP URL generation logic in `ObservationRecordDetailView`.
- If the GPP URL can be generated, it will be displayed as an enabled button linking to the GPP page for the observation.

Author: davner

docs/changes/488.new.rst

@@ -0,0 +1 @@
+Added the link to Gemini Explore for observations with GPP-style IDs on the observation detail page.

src/goats_tom/facilities/gemini.py

@@ -47,6 +47,8 @@
 
 ocs_client = OCSClient()
 
+
+
 class GEMObservationForm(BaseRoboticObservationForm):
     gpp_id = forms.CharField(required=True)
     observation_id = forms.CharField(required=True)
@@ -56,6 +58,7 @@ class GEMObservationForm(BaseRoboticObservationForm):
     cloud_extinction = forms.CharField(required=False)
     sky_background = forms.CharField(required=False)
     water_vapor = forms.CharField(required=False)
+    gpp_program_id = forms.CharField(required=False)
 
     # All FIELD_MAP keys are relative to `observing_parameters`, which is passed
     # directly as the `data` dict to this form. So do NOT prefix paths with
@@ -71,6 +74,7 @@ class GEMObservationForm(BaseRoboticObservationForm):
         "water_vapor": "constraintSet.waterVapor",
         "target_id": "target_id",
         "facility": "facility",
+        "gpp_program_id": "program.id",
     }
 
     FIELD_MAP = {}

src/goats_tom/templates/tom_observations/observationrecord_detail.html

@@ -16,11 +16,15 @@ <h2>{{ object.observation_id }} @{{ object.facility }}</h2>
     {% if editable %}
       <p>{% update_observation_id_form object %}</p>
     {% endif %}
-    {% if object.url %}
     <p class="my-auto pb-3">
-      <a class="btn btn-outline-primary {% if object.facility == 'GEM' %}disabled{% endif %}" href="{{ object.url }}" target="_blank">View at Observatory »</a>
+      <a
+        class="btn btn-outline-primary {% if not gpp_url %}disabled{% endif %}"
+        href="{{ gpp_url|default:'#' }}"
+        target="_blank"
+      >
+        View at Observatory »
+      </a>
     </p>
-    {% endif %}
     <p class="my-auto"><strong>Created:</strong> {{ object.created }} <strong>Modified:</strong> {{ object.modified }}</p>
     <p class="my-auto"><strong>Status:</strong> {{ object.status }}</p>
   </div>

src/goats_tom/templatetags/gemini.py

@@ -1,8 +1,3 @@
-# Standard library imports.
-
-# Related third party imports.
-
-# Local application/library specific imports.
 from typing import Any
 
 from django import template

src/goats_tom/views/observation_record_detail.py

@@ -1,4 +1,8 @@
 __all__ = ["ObservationRecordDetailView"]
+import logging
+import re
+from typing import Any
+
 from django.urls import reverse
 from django.views.generic import DetailView
 from tom_dataproducts.forms import AddProductToGroupForm, DataProductUploadForm
@@ -10,6 +14,26 @@
     ObservationRecordDetailView as BaseObservationRecordDetailView,
 )
 
+logger = logging.getLogger(__name__)
+
+
+def _is_gpp_id(obs_id: str) -> bool:
+    """
+    Return True if the observation ID is a GPP-style ID, otherwise False.
+
+    Parameters
+    ----------
+    obs_id : str
+        The observation ID to check.
+
+    Returns
+    -------
+    bool
+        True if it is a GPP ID (e.g., G-2026A-0166-Q-0001), False otherwise.
+    """
+    pattern = re.compile(r"^G-(?![NS]-)")
+    return bool(pattern.match(obs_id))
+
 
 class ObservationRecordDetailView(BaseObservationRecordDetailView):
     """View to override creating thumbnails."""
@@ -39,4 +63,27 @@ def get_context_data(self, *args, **kwargs):
         )
         context["data_product_form"] = data_product_upload_form
         context["observation_id"] = observation_record.observation_id
+        # Add GPP URL if applicable
+        context["gpp_url"] = self._get_gpp_url(observation_record)
         return context
+
+    @staticmethod
+    def _get_gpp_url(observation_record: Any) -> str | None:
+        """Return the Explore URL if this is a GPP Gemini observation."""
+        if (
+            not _is_gpp_id(observation_record.observation_id)
+            or observation_record.facility != "GEM"
+        ):
+            return None
+
+        try:
+            program_id = observation_record.parameters.get("gpp_program_id")
+            obs_id = observation_record.parameters.get("gpp_id")
+            if program_id and obs_id:
+                return f"https://explore.gemini.edu/{program_id}/observation/{obs_id}"
+        except Exception:
+            logger.exception(
+                "Failed to build GPP URL for observation %s",
+                observation_record.observation_id,
+            )
+        return None