Commit a179380
authored
Collection block bug fixes (#1852)
- Navigate the row-actions relation icon to the relation's `entityId` rather than its `id`, matching LinkableRelationChip. The previous URL pointed at a non-existent entity. Lookup is deferred until the popover opens, so list/gallery views (which mount the component per row) don't pay an O(rows × relations) scan on every render.
- Keep the row-actions popover open while its nested space selector is active. The selector's content is portaled outside the outer popover's DOM, so opening it fired `onFocusOutside` on the outer Content and unmounted both. Suppress the outer's dismiss handlers while the nested popover is open and close it explicitly on selection.
- `SelectSpaceAsPopover` gains optional controlled `open`/`onOpenChange` props (used by the row-actions wrapper above). The props are typed as a discriminated union so passing `open` without `onOpenChange` is a type error — otherwise Radix could end up stuck open with no updater.1 parent 8ae8659 commit a179380
2 files changed
Lines changed: 49 additions & 5 deletions
File tree
- apps/web
- design-system
- partials/blocks/table
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
16 | 30 | | |
17 | | - | |
| 31 | + | |
18 | 32 | | |
19 | 33 | | |
20 | 34 | | |
| |||
Lines changed: 32 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
| |||
68 | 74 | | |
69 | 75 | | |
70 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
71 | 92 | | |
72 | 93 | | |
73 | 94 | | |
| |||
106 | 127 | | |
107 | 128 | | |
108 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
109 | 136 | | |
110 | 137 | | |
111 | 138 | | |
112 | 139 | | |
113 | 140 | | |
114 | 141 | | |
115 | 142 | | |
| 143 | + | |
116 | 144 | | |
117 | 145 | | |
118 | 146 | | |
| |||
121 | 149 | | |
122 | 150 | | |
123 | 151 | | |
| 152 | + | |
| 153 | + | |
124 | 154 | | |
125 | 155 | | |
126 | 156 | | |
| 157 | + | |
127 | 158 | | |
128 | 159 | | |
129 | 160 | | |
130 | 161 | | |
131 | 162 | | |
132 | | - | |
133 | 163 | | |
134 | 164 | | |
135 | 165 | | |
| |||
145 | 175 | | |
146 | 176 | | |
147 | 177 | | |
148 | | - | |
| 178 | + | |
149 | 179 | | |
150 | 180 | | |
151 | 181 | | |
| |||
0 commit comments