Skip to content

Autocomplete mode #1120

Open
Open
@jbelien

Description

@jbelien

The last 2 PR are aiming to add autocomplete support.

I like the idea but I think we need to figure out a consistent way to implement that across all providers that offer autocompletion.


#1118 by @nassuf

$query->withData('autocomplete', true);

#1119 by @gdw96

$query->withData('mode', GoogleMapsPlaces::GEOCODE_MODE_AUTOCOMPLETE);

Personally, I would go for a new AutocompleteQuery class (see src/Common/Query) so we make it consistent and structured for every provider.
That being said, we would probably need to check how many provider offer autocompletion to see if it worth it.

Otherwise, I would go for solution 2 here above that seems more flexible.

Any insight on this topic @Nyholm @willdurand ?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions