Merge branch 'main' of https://github.com/geode-sdk/DevTools into drag-button

Author: Kingminer7

.github/workflows/build.yml

@@ -2,6 +2,7 @@ name: Build Geode Mod
 
 on:
   workflow_dispatch:
+  pull_request:
   push:
     branches:
       - '**'

CMakeLists.txt

@@ -34,6 +34,13 @@ target_sources(${PROJECT_NAME} PRIVATE
     ${imgui_SOURCE_DIR}/misc/cpp/imgui_stdlib.cpp
 )
 
+# Love you imgui
+include(CheckCXXCompilerFlag)
+check_cxx_compiler_flag(-Wnontrivial-memcall HAVE_NONTRIVIAL_MEMCALL)
+if (HAVE_NONTRIVIAL_MEMCALL)
+    target_compile_options(${PROJECT_NAME} PRIVATE -Wno-nontrivial-memcall)
+endif()
+
 # i still dont like this (alk)
 target_compile_definitions(geode-sdk INTERFACE GEODE_EXPOSE_SECRET_INTERNALS_IN_HEADERS_DO_NOT_DEFINE_PLEASE)
 

src/DevTools.cpp

@@ -1,4 +1,3 @@
-
 #include <imgui_internal.h>
 #include "DevTools.hpp"
 #include "fonts/FeatherIcons.hpp"
@@ -203,11 +202,15 @@ void DevTools::setupFonts() {
         void* font, size_t realSize, float size, const ImWchar* range
     ) {
         auto& io = ImGui::GetIO();
+        // AddFontFromMemoryTTF assumes ownership of the passed data unless you configure it not to.
+        // Our font data has static lifetime, so we're handling the ownership.
+
         ImFontConfig config;
-        config.MergeMode = true;
+        config.FontDataOwnedByAtlas = false;
         auto* result = io.Fonts->AddFontFromMemoryTTF(
-            font, realSize, size, nullptr, range
+            font, realSize, size, &config, range
         );
+        config.MergeMode = true;
         io.Fonts->AddFontFromMemoryTTF(
             Font_FeatherIcons, sizeof(Font_FeatherIcons), size - 4.f, &config, icon_ranges
         );
@@ -227,7 +230,7 @@ void DevTools::setup() {
 
     IMGUI_CHECKVERSION();
 
-    auto ctx = ImGui::CreateContext();
+    ImGui::CreateContext();
 
     auto& io = ImGui::GetIO();
     io.ConfigFlags |= ImGuiConfigFlags_DockingEnable;
@@ -248,23 +251,27 @@ void DevTools::setup() {
 
 void DevTools::destroy() {
     if (!m_setup) return;
-    m_setup = false;
-    m_visible = false;
+    this->show(false);
+    auto& io = ImGui::GetIO();
+    io.BackendPlatformUserData = nullptr;
+    m_fontTexture->release();
+    m_fontTexture = nullptr;
 
-    // crashes :(
-    // ImGui::DestroyContext();
+    ImGui::DestroyContext();
+    m_setup = false;
+    m_reloadTheme = true;
 }
 
 void DevTools::show(bool visible) {
     m_visible = visible;
+
+    auto& io = ImGui::GetIO();
+    io.WantCaptureMouse = visible;
+    io.WantCaptureKeyboard = visible;
 }
 
 void DevTools::toggle() {
     this->show(!m_visible);
-    if (!m_visible) {
-        ImGui::GetIO().WantCaptureMouse = false;
-        ImGui::GetIO().WantCaptureKeyboard = false;
-    }
 }
 
 void DevTools::sceneChanged() {

src/DevTools.hpp

@@ -8,7 +8,6 @@
 #include <Geode/utils/addresser.hpp>
 #include <Geode/loader/Loader.hpp>
 #include <Geode/loader/ModMetadata.hpp>
-#include <unordered_map>
 
 using namespace geode::prelude;
 
@@ -49,6 +48,7 @@ class DevTools {
     ImFont* m_smallFont    = nullptr;
     ImFont* m_monoFont     = nullptr;
     ImFont* m_boxFont      = nullptr;
+    CCTexture2D* m_fontTexture = nullptr;
     Ref<CCNode> m_selectedNode;
     std::vector<std::pair<CCNode*, HighlightMode>> m_toHighlight;
 

src/backend.cpp

@@ -11,9 +11,30 @@ using namespace cocos2d;
 
 // based off https://github.com/matcool/gd-imgui-cocos
 
-void DevTools::setupPlatform() {
-    ImGui::CreateContext();
+static bool g_useNormalPos = false;
+
+CCPoint getMousePos_H() {
+    CCPoint mouse = cocos::getMousePos();
+    const auto pos = toVec2(mouse);
+
+    if (DevTools::get()->shouldUseGDWindow() && shouldPassEventsToGDButTransformed() && !g_useNormalPos) {
+        auto win = ImGui::GetMainViewport()->Size;
+        const auto gdRect = getGDWindowRect();
 
+        auto relativePos = ImVec2(
+            pos.x - gdRect.Min.x,
+            pos.y - gdRect.Min.y
+        );
+        auto x = (relativePos.x / gdRect.GetWidth()) * win.x;
+        auto y = (relativePos.y / gdRect.GetHeight()) * win.y;
+
+        mouse = toCocos(ImVec2(x, y));
+    }
+    
+    return mouse;
+}
+
+void DevTools::setupPlatform() {
     auto& io = ImGui::GetIO();
 
     io.BackendPlatformUserData = this;
@@ -29,13 +50,20 @@ void DevTools::setupPlatform() {
     int width, height;
     io.Fonts->GetTexDataAsRGBA32(&pixels, &width, &height);
 
-    auto* tex2d = new CCTexture2D;
-    tex2d->initWithData(pixels, kCCTexture2DPixelFormat_RGBA8888, width, height, CCSize(width, height));
+    m_fontTexture = new CCTexture2D;
+    m_fontTexture->initWithData(pixels, kCCTexture2DPixelFormat_RGBA8888, width, height, CCSize(width, height));
+    m_fontTexture->retain();
 
-    // TODO: not leak this :-)
-    tex2d->retain();
+    io.Fonts->SetTexID(reinterpret_cast<ImTextureID>(static_cast<intptr_t>(m_fontTexture->getName())));
 
-    io.Fonts->SetTexID(reinterpret_cast<ImTextureID>(static_cast<intptr_t>(tex2d->getName())));
+    // fixes getMousePos to be relative to the GD view
+    #ifndef GEODE_IS_MOBILE
+    (void) Mod::get()->hook(
+        reinterpret_cast<void*>(addresser::getNonVirtual(&geode::cocos::getMousePos)),
+        &getMousePos_H,
+        "geode::cocos::getMousePos"
+    );
+    #endif
 }
 
 void DevTools::newFrame() {
@@ -54,7 +82,9 @@ void DevTools::newFrame() {
     io.DeltaTime = director->getDeltaTime();
 
 #ifdef GEODE_IS_DESKTOP
+    g_useNormalPos = true;
     const auto mousePos = toVec2(geode::cocos::getMousePos());
+    g_useNormalPos = false;
     io.AddMousePosEvent(mousePos.x, mousePos.y);
 #endif
 

src/pages/Attributes.cpp

@@ -4,6 +4,8 @@
 #include <misc/cpp/imgui_stdlib.h>
 #include <Geode/binding/CCMenuItemSpriteExtra.hpp>
 #include "../platform/utils.hpp"
+#include <ccTypes.h>
+#include <Geode/ui/Layout.hpp>
 
 using namespace geode::prelude;
 
@@ -132,7 +134,7 @@ void DevTools::drawNodeAttributes(CCNode* node) {
         auto color = rgbaNode->getColor();
         float _color[4] = { color.r / 255.f, color.g / 255.f, color.b / 255.f, rgbaNode->getOpacity() / 255.f };
         if (ImGui::ColorEdit4("Color", _color)) {
-            rgbaNode->setColor(ccColor3B{
+            rgbaNode->setColor(ccColor3B {
                 static_cast<GLubyte>(_color[0] * 255),
                 static_cast<GLubyte>(_color[1] * 255),
                 static_cast<GLubyte>(_color[2] * 255)

src/pages/GeometryDash.cpp

@@ -4,6 +4,7 @@
 #include <Geode/utils/ranges.hpp>
 #include <Geode/binding/FLAlertLayer.hpp>
 #include <Geode/binding/GJDropDownLayer.hpp>
+#include <Geode/ui/Layout.hpp>
 
 void drawRowAxisArrow(
     ImDrawList& foreground,
@@ -285,8 +286,8 @@ void DevTools::drawGD(GLRenderCtx* gdCtx) {
 
             auto pad = ImGui::GetStyle().FramePadding.x;
 
-            auto winPos = ImGui::GetCursorScreenPos();
-            auto winSize = ImGui::GetContentRegionAvail();
+            auto winPos = ImGui::GetCursorScreenPos();
+            auto winSize = ImGui::GetContentRegionAvail();
 
             ImVec2 imgSize = {
                 (winSize.y - pad * 2) * ratio,

src/pages/Settings.cpp

@@ -6,6 +6,7 @@
 #include <Geode/modify/AppDelegate.hpp>
 #include <fmod.hpp>
 #include <numeric>
+#include <Geode/binding/GameManager.hpp>
 #include "../nodes/DragButton.hpp"
 
 using namespace geode::prelude;