Merge pull request #6103 from bangerth/cleanup

Microscropic clean-ups.

Author: gassmoeller

include/aspect/utilities.h

@@ -672,7 +672,7 @@ namespace aspect
      */
     void create_directory(const std::string &pathname,
                           const MPI_Comm comm,
-                          bool silent);
+                          const bool silent);
 
     /**
      * A namespace defining the cubic spline interpolation that can be used

source/postprocess/gravity_point_values.cc

@@ -697,7 +697,7 @@ namespace aspect
     void
     GravityPointValues<dim>::parse_parameters (ParameterHandler &prm)
     {
-      std::string gravity_subdirectory = this->get_output_directory() + "output_gravity/";
+      const std::string gravity_subdirectory = this->get_output_directory() + "output_gravity/";
       Utilities::create_directory (gravity_subdirectory,
                                    this->get_mpi_communicator(),
                                    true);

source/postprocess/visualization.cc

@@ -1335,7 +1335,7 @@ namespace aspect
               ExcMessage ("No postprocessors registered!?"));
       std::vector<std::string> viz_names;
 
-      std::string visualization_subdirectory = this->get_output_directory() + "solution/";
+      const std::string visualization_subdirectory = this->get_output_directory() + "solution/";
       Utilities::create_directory (visualization_subdirectory,
                                    this->get_mpi_communicator(),
                                    true);

source/utilities.cc

@@ -1658,7 +1658,6 @@ namespace aspect
           int mkdir_return_value;
           if ((mkdir_return_value = mkdir(subdir.c_str(),mode)) && (errno != EEXIST))
             return mkdir_return_value;
-
         }
 
       return 0;
@@ -1668,7 +1667,7 @@ namespace aspect
 
     void create_directory(const std::string &pathname,
                           const MPI_Comm comm,
-                          bool silent)
+                          const bool silent)
     {
       // verify that the output directory actually exists. if it doesn't, create
       // it on processor zero
@@ -1689,7 +1688,6 @@ namespace aspect
                           << std::endl;
 
               error = Utilities::mkdirp(pathname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH);
-
             }
           else
             {