-
Notifications
You must be signed in to change notification settings - Fork 258
Implementation of plastic dilation #6373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Changed: The prescribed dilation is now split into two parts: a | ||
| pressure-dependent part that is moved to the left-hand side of the mass | ||
| conservation equation, and a pressure-independent part that stays on the | ||
| right-hand side. In addition, the effect of dilation on the momentum | ||
| conservation equation for incompressible models is no longer represented by | ||
| the dilation term on the right-hand side, but by the volumetric strain rate | ||
| term on the left-hand side. These changes enable the Drucker-Prager model | ||
| to produce associated plastic flows, in which the shear bands develop along | ||
| the Coulomb angle. | ||
| <br> | ||
| (Yimin Jin, 2025/06/16) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,20 @@ namespace aspect | |
| * All the drucker prager plasticity parameters. | ||
| */ | ||
| std::vector<Rheology::DruckerPragerParameters> drucker_prager_parameters; | ||
|
|
||
| /** | ||
| * The LHS term corresponding to plastic dilation in the | ||
| * Stokes system. For details, see the comments of | ||
| * MaterialModel::PrescribedDilation::dilation_lhs_term. | ||
| */ | ||
| std::vector<double> dilation_lhs_terms; | ||
|
|
||
| /** | ||
| * The RHS term corresponding to plastic dilation in the | ||
| * Stokes system. For details, see the comments of | ||
| * MaterialModel::PrescribedDilation::dilation_rhs_term. | ||
| */ | ||
| std::vector<double> dilation_rhs_terms; | ||
|
Comment on lines
+106
to
+118
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this code part looks different since #6384. Please rebase, the new version will be simpler, because it includes the |
||
| }; | ||
|
|
||
| namespace Rheology | ||
|
|
@@ -143,7 +157,7 @@ namespace aspect | |
| */ | ||
| void compute_viscosity_derivatives(const unsigned int point_index, | ||
| const std::vector<double> &volume_fractions, | ||
| const std::vector<double> &composition_viscosities, | ||
| const IsostrainViscosities &isostrain_values, | ||
| const MaterialModel::MaterialModelInputs<dim> &in, | ||
| MaterialModel::MaterialModelOutputs<dim> &out, | ||
| const std::vector<double> &phase_function_values = std::vector<double>(), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this description is pretty specific to the case of plastic dilation, but not the general case of someone prescribing delation because of other processes. Maybe it would be better to limit this documentation to the discussion of where the individual terms will go into the equation, and move the specific parts to
drucker_prager.h:145