Split radial gravity plugins into separate files #6681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #6614 I saw that we pack three gravity plugins into one file. This is not completely unreasonable as they are all quite small. However, I think in line with keeping all plugin files as similar as possible to each other it would be more intuitive to pack one plugin per file as we do almost everywhere else. I split the classes into separate files and deprecated the old header file (it still includes the three new files, so existing code continues to work).
Let me know if the deprecation message using the
#pragma messageapproach is the best way to notify users.