Add GMG global coarsening test for 2d shell. [WIP] #6752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
are iterations numbers similar between GC and LS? Also for meshes that are a bit finer? If yes, I am okay to remove the assert and merge this PR. |
bangerth
reviewed
Nov 13, 2025
Comment on lines
1575
to
+1577
| if (this->get_boundary_velocity_manager().get_tangential_boundary_velocity_indicators().size() > 0) | ||
| { | ||
| Assert(false, dealii::StandardExceptions::ExcNotImplemented("This is not tested.")); | ||
| // Assert(false, dealii::StandardExceptions::ExcNotImplemented("This is not tested.")); |
Contributor
There was a problem hiding this comment.
If you remove the assert, just remove it. The current state of the code base should represent the current state, not some previously present assertion -- that is just bound to confuse readers. If you think the code is now well tested, let's just remove the assertion. If you don't think that the code is well tested, then of course we should not remove the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds another test for GMG global coarsening. Work in progress until test results are updated.