AsciiDataLayered: remove redundant data_dir #6769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
force-pushed
the
layered-structured-data-remove-datadir
branch
from
e79da88 to
65a1b29
Compare
gassmoeller
reviewed
Nov 11, 2025
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
Yes, generally correct, but now you need to qualify data_directory as this->data_directory in structured_data.cc:1592.
This class is derived from AsciiDataBase that already contains and parses data_directory.
tjhei
force-pushed
the
layered-structured-data-remove-datadir
branch
from
65a1b29 to
17146f0
Compare
Member
Author
|
Fixed, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is derived from AsciiDataBase that already contains and parses data_directory.