Refactored line search functionality for do_one_defect_correction_Stokes_step in solver_schemes.cc #6772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Nov 11, 2025
source/simulator/helper_functions.cc
Outdated
| * Performs a Newton line search for the do_one_defect_correction_Stokes_step function | ||
| */ | ||
| template <int dim> | ||
| void Simulator<dim>::perform_line_search(const DefectCorrectionResiduals &dcr, const bool use_picard, LinearAlgebra::BlockVector &search_direction) |
Contributor
There was a problem hiding this comment.
same here:
- return step length
- one argument per line
|
|
||
| /** | ||
| * Perform a newton line search to determine the optimal step length | ||
| * along the search direction. |
Contributor
There was a problem hiding this comment.
Also say that the result of the function is that current_linearization_point is set to the old current_linearization_point plus a suitable update in direction of search_direction.
arnoldkk13
force-pushed
the
defect_correction_stokes_refactor
branch
from
8a53156 to
90b1500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Refactored the Newton line search functionality in do_one_defect_correction_Stokes_step into a new function in helper_functions.cc.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: