Better document a workflow. #6773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Nov 12, 2025
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
The change makes sense, but please fix the accidentally committed conflict.
Comment on lines
614
to
631
| <<<<<<< Updated upstream | ||
| ======= | ||
| ar &(*initial_temperature_manager); | ||
| ar &(*initial_composition_manager); | ||
| ar &boundary_temperature_manager; | ||
| ar &boundary_convective_heating_manager; | ||
| ar &boundary_composition_manager; | ||
| ar &prescribed_solution_manager; | ||
| ar &boundary_convective_heating_manager; | ||
| ar &boundary_velocity_manager; | ||
| ar &boundary_traction_manager; | ||
| ar &prescribed_solution_manager; | ||
|
|
||
| // The following two are not manager classes but straight up plugins and so don't | ||
| // The following are not manager classes but straight up plugins and so don't | ||
| // currently have the ability to serialize themselves. We should add those later. | ||
| // ar &prescribed_stokes_solution; | ||
| // ar &boundary_heat_flux; | ||
|
|
||
| // By definition, a checkpoint is past the first time step. As a consequence, | ||
| // the Simulator object will not need the initial conditions objects, and | ||
| // we do not need to serialize those | ||
| // ar &(*adiabatic_conditions); | ||
| // ar &(*initial_topography_model); | ||
| >>>>>>> Stashed changes |
Member
There was a problem hiding this comment.
I think you committed this accidentally.
Contributor
Author
|
Yes, sorry for the miscued commit. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnoldkk13 FYI