Equilibration tolerances #676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling of solver tolerances in the equilibration routines, making them more flexible and robust. The changes allow the tolerance parameter (
tol) to be specified as either a single float or a per-parameter array, with sensible defaults provided when not specified. The documentation and tests have been updated to reflect and validate these changes.Enhancements to tolerance handling:
tolparameter inequilibrateand related functions can now be a float or a 1D numpy array, with default tolerances set for each parameter iftolis not provided. This allows for finer control and clearer defaults for pressure, temperature, phase amounts, and compositional vectors. [1] [2] [3]nonlinear_solvers.pyensures that array tolerances are 1D and match the number of parameters, raising informative errors if mismatched.Documentation and usability improvements:
equilibrateand related functions have been updated to clearly describe the new behavior and default values for the tolerance parameter.Testing and backward compatibility:
equilibratein the SLB2024 benchmark script have been updated to use the new default tolerance behavior, removing explicittolarguments for simplicity. [1] [2] [3] [4] [5]