refactored optimal thermobarometry #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modularizes the code for thermobarometric inversion in
burnman.tools.thermobarometry, extracting reusable functions for reaction matrix construction, assemblage state setting, and affinity misfit calculation from theestimate_conditionsfunction.Summary of changes:
get_reaction_matrix,assemblage_set_state_from_params, andassemblage_affinity_misfitfunctions to encapsulate core steps in thermobarometric inversion, improving code reuse and clarity.estimate_conditionsfunction to use these new utilities, streamline the optimization logic, and support optional priors on pressure and temperature viacondition_priorsandcondition_covariancesarguments.