Merge pull request #794 from baagaard-usgs/feature-sanitize-configure-option

Add ability to build library with -fsanitize=address to help detect memory errors

Author: baagaard-usgs

configure.ac

@@ -48,6 +48,18 @@ AC_ARG_WITH([python-coverage],
 	[python_coverage="coverage2"])
 AC_SUBST(python_coverage)
 
+dnl sanitizer
+AC_ARG_ENABLE([sanitizer],
+    [AC_HELP_STRING([--enable-sanitizer],
+        [enable compiling C++ code with -fsanitizer @<:@default=no@:>@])],
+	[if test "$enableval" != no; then enable_sanitizer=yes; else enable_sanitizer=no; fi;
+	if test "$enableval" = yes; then sanitizer=address; else sanitizer=$enableval; fi],
+	[enable_sanitizer=no])
+if test "$enable_sanitizer" = "yes"; then
+  SANITIZER_CXXFLAGS="-fsanitize=$sanitizer"; export SANITIZER_CXXFLAGS
+fi
+AC_SUBST(SANITIZER_CXXFLAGS)
+
 dnl CUBIT I/O w/netcdf
 AC_ARG_ENABLE([cubit],
     [AC_HELP_STRING([--enable-cubit],

libsrc/pylith/Makefile.am

@@ -146,7 +146,7 @@ libpylith_la_SOURCES = \
 	utils/TestArray.cc
 
 
-
+libpylith_la_CXXFLAGS = $(SANITIZER_CXXFLAGS)
 libpylith_la_LDFLAGS = $(AM_LDFLAGS) $(PYTHON_LDFLAGS) $(PYTHON_LA_LDFLAGS)
 libpylith_la_LIBADD = \
 	-lspatialdata \

libsrc/pylith/topology/Field.cc

@@ -590,7 +590,7 @@ pylith::topology::Field::getSubfieldNames(void) const {
         names[sinfo.index] = s_iter->first;
     } // for
 
-    PYLITH_METHOD_RETURN(pylith::string_vector(names));
+    PYLITH_METHOD_RETURN(names);
 } // subfieldNames
 
 
@@ -599,6 +599,7 @@ pylith::topology::Field::getSubfieldNames(void) const {
 const pylith::topology::Field::SubfieldInfo&
 pylith::topology::Field::getSubfieldInfo(const char* name) const {
     PYLITH_METHOD_BEGIN;
+    assert(name);
 
     subfields_type::const_iterator iter = _subfields.find(name);
     if (_subfields.end() == iter) {