Shouldn't controller.setValue() call onFinishChange?

[victorpoughon]

Currently, controller.setValue( value ) invokes any registered onChange() handlers. Shouldn't it also call any registered onFinishChange() handler? Seems a bit inconsistent that it doesn't.

Looking at the code, controller.load(value) seems to do this, but it's not documented. Is it safe to use it to achieve that?

[georgealways]

Hey, you're not wrong! The reason for that is controllers use setValue internally, and I wanted them to be responsible for determining when the change is "finished."

Maybe the signature should be more like setValue( value, finished = true ), I'll take a look.

Yes controller.load already does this.