fix: praise be linters & fix test

Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

Author: georglauterbach

.github/workflows/release.yml

@@ -50,6 +50,7 @@ jobs:
           echo 'Setting up git'
           git config --global user.email 'github-actions[bot]@users.noreply.github.com'
           git config --global user.name 'github-actions[bot]'
+          git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git
           git config pull.rebase false
 
           echo 'Creating new branch'

.vscode/settings.json

@@ -6,7 +6,6 @@
   ],
   "shellcheck.run": "onSave",
   "shellcheck.customArgs": [
-    "--shell=sh",
     "--severity=style",
     "--extended-analysis=true",
     "--source-path=SCRIPTDIR",

test/lang-rust/lib.sh

@@ -1,67 +1,67 @@
-#! /bin/sh
+#! /usr/bin/env bash
 
 # -----------------------------------------------
 # ----  Source third-party libraries  -----------
 # -----------------------------------------------
 
 # shellcheck source=/dev/null
-. dev-container-features-test-lib
+source dev-container-features-test-lib
 
 # shellcheck disable=SC2034
-readonly DATA_BASE_DIR='/opt/devcontainer/features/ghcr_io/georglauterbach'
+readonly DATA_BASE_DIR='/usr/local/share/dev_containers/features/ghcr_io/georglauterbach'
 
 # -----------------------------------------------
 # ----  Assertions  -----------------------------
 # -----------------------------------------------
 
-__expect_failure() {
-  sh -c "${*}" && return 1
+function __expect_failure() {
+  bash -c "${*}" && return 1
   return 0
 }
 
-assert_failure() {
-  __TEST_NAME="${1:?Name of the test required}"
+function assert_failure() {
+  local TEST_NAME="${1:?Name of the test required}"
   shift 1
 
-  check "expect::failure|${__TEST_NAME}" __expect_failure "${@}"
+  check "expect::failure|${TEST_NAME}" __expect_failure "${@}"
 }
 
-assert_success() {
-  __TEST_NAME="${1:?Name of the test required}"
+function assert_success() {
+  local TEST_NAME="${1:?Name of the test required}"
   shift 1
 
-  check "expect::success|${__TEST_NAME}" sh -c "${*}"
+  check "expect::success|${TEST_NAME}" bash -c "${*}"
 }
 
 # -----------------------------------------------
 # ----  Helper  ---------------------------------
 # -----------------------------------------------
 
-command_exists() {
+function command_exists() {
   assert_success "command::${1}" command -v "${1}"
 }
 
-command_exists_not() {
+function command_exists_not() {
   assert_failure "command::${1}" command -v "${1}"
 }
 
-dir_exists() {
-  assert_success "directory::${1}" "[ -d \"${1}\" ]"
+function dir_exists() {
+  assert_success "directory::${1}" "[[ -d ${1} ]]"
 }
 
-dir_exists_not() {
-  assert_failure "directory::${1}" "[ -d \"${1}\" ]"
+function dir_exists_not() {
+  assert_failure "directory::${1}" "[[ -d ${1} ]]"
 }
 
-file_exists() {
-  assert_success "file::${1}" "[ -f \"${1}\" ]"
+function file_exists() {
+  assert_success "file::${1}" "[[ -f ${1} ]]"
 }
 
-file_exists_not() {
-  assert_failure "file::${1}" "[ -f \"${1}\" ]"
+function file_exists_not() {
+  assert_failure "file::${1}" "[[ -f ${1} ]]"
 }
 
-env_is_set_with_value() {
-  assert_success "env::set::${1}" "[ -v \"${1}\" ]"
-  assert_success "env::set::${1}" "[ \"${1}\" = \"${2}\" ]"
+function env_is_set_with_value() {
+  assert_success "env::set::${1}" "[[ -v ${1} ]]"
+  assert_success "env::set::${1}" "[[ ${1} == ${2} ]]"
 }

test/lang-rust/test.sh

@@ -1,7 +1,9 @@
-#! /bin/sh
+#! /bin/bash
 
-set -e -u
-. lib.sh
+set -eE -u -o pipefail
+shopt -s inherit_errexit
+
+source lib.sh
 
 assert_success :
 

test/lang-rust/ubuntu2404-basics.sh

@@ -1,7 +1,9 @@
-#! /bin/sh
+#! /bin/bash
 
-set -e -u
-. lib.sh
+set -eE -u -o pipefail
+shopt -s inherit_errexit
+
+source lib.sh
 
 file_exists "${DATA_BASE_DIR}/rust/rustup/home/rustup-init"