ci: praise be linters & enable external sources in ShellCheck by default

Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

Author: georglauterbach

.vscode/settings.json

@@ -1,5 +1,6 @@
 {
   "shellcheck.customArgs": [
-    "--rcfile=.shellcheckrc"
-  ]
+    "--rcfile=.shellcheckrc",
+    "--external-sources"
+  ],
 }

src/lang-sh/devcontainer-feature.json

@@ -34,7 +34,8 @@
         "shellcheck.run": "onSave",
         // supply custom arguments to make the most use of ShellCheck
         "shellcheck.customArgs": [
-          "--rcfile=/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_bash/shellcheck.conf"
+          "--rcfile=/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_bash/shellcheck.conf",
+          "--external-sources"
         ]
       }
     }

src/nodejs/README.md

@@ -17,7 +17,7 @@ Install NodeJS
 |-----|-----|-----|-----|
 | version | Version of NodeJS to install | string | 25.0.0 |
 | architecture | Architecture of NodeJS to install | string | x64 |
-| uri | Non-default mirror for the `tar.xz`/`tar.gz` archive that contains NodeJS files. You can specify the version directly or use the string `<<VERSION>>` which is replaced by `node.version` | string | https://nodejs.org/dist/v<<VERSION>>/node-v<<VERSION>>-linux-<<ARCHITECTURE>>.tar.xz |
+| uri | Non-default mirror for the `tar.xz`/`tar.gz` archive that contains NodeJS files. You can specify the version directly or use the string `{{VERSION}}` which is replaced by `node.version` | string | https://nodejs.org/dist/v{{VERSION}}/node-v{{VERSION}}-linux-{{ARCHITECTURE}}.tar.xz |
 | proxy.http.http.address | A URI for an HTTP proxy | string | - |
 | proxy.http.https.address | A URI for an HTTPS proxy | string | - |
 | proxy.http.no-proxy.address | A list of URIs to not proxy | string | localhost,127.0.0.1 |

src/nodejs/devcontainer-feature.json

@@ -17,9 +17,9 @@
       "default": "x64"
     },
     "uri": {
-      "description": "Non-default mirror for the `tar.xz`/`tar.gz` archive that contains NodeJS files. You can specify the version directly or use the string `<<VERSION>>` which is replaced by `node.version`",
+      "description": "Non-default mirror for the `tar.xz`/`tar.gz` archive that contains NodeJS files. You can specify the version directly or use the string `{{VERSION}}` which is replaced by `node.version`",
       "type": "string",
-      "default": "https://nodejs.org/dist/v<<VERSION>>/node-v<<VERSION>>-linux-<<ARCHITECTURE>>.tar.xz"
+      "default": "https://nodejs.org/dist/v{{VERSION}}/node-v{{VERSION}}-linux-{{ARCHITECTURE}}.tar.xz"
     },
     "proxy.http.http.address": {
       "description": "A URI for an HTTP proxy",

src/nodejs/install.sh

@@ -57,8 +57,8 @@ parse_dev_container_options() {
 
 install_node() {
   DOWNLOAD_URL=$(printf '%s' "${URI}" | sed \
-    -e "s|<<VERSION>>|${VERSION}|g" \
-    -e "s|<<ARCHITECTURE>>|${ARCHITECTURE}|g")
+    -e "s|{{VERSION}}|${VERSION}|g" \
+    -e "s|{{ARCHITECTURE}}|${ARCHITECTURE}|g")
   FILE_NAME=$(basename "${DOWNLOAD_URL}")
   readonly DOWNLOAD_URL FILE_NAME