chore: rename lang_bash => lang_sh & add ShellCheck config

Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

Author: georglauterbach

.shellcheckrc

@@ -0,0 +1,10 @@
+shell=sh
+
+enable=all
+color=auto
+severity=style
+disable=SC2312
+external-sources=true
+check-sourced=true
+source-path=SCRIPTDIR
+wiki-link-count=5

.vscode/settings.json

@@ -1,15 +1,5 @@
 {
-  "shellcheck.useWorkspaceRootAsCwd": false,
-  "shellcheck.exclude": [
-    "2310",
-    "2312"
-  ],
-  "shellcheck.run": "onSave",
   "shellcheck.customArgs": [
-    "--severity=style",
-    "--extended-analysis=true",
-    "--source-path=SCRIPTDIR",
-    "--external-sources",
-    "--color=auto"
+    "--rcfile=.shellcheckrc"
   ]
 }

cspell.config.yaml

@@ -25,5 +25,6 @@ ignoreWords:
   - trixie
 
   # multiple words written as one
+  - cooldown
   - devcontainers
   - libbash

src/lang-bash/install.sh

@@ -2,10 +2,17 @@
 // cSpell: ignore timonwong
 {
   "id": "lang-bash",
-  "version": "0.1.1",
+  "version": "0.2.0",
   "name": "Programming Language | Bash",
   "documentationURL": "https://github.com/georglauterbach/dev-container-features/tree/main/src/lang-bash",
   "description": "Work efficiently and effortlessly with Bash",
+  "options": {
+    "copy-libbash": {
+      "description": "whether to copy [`libbash`](https://github.com/georglauterbach/libbash) v9.0.0 to `/usr/local/lib/`",
+      "type": "boolean",
+      "default": true
+    }
+  },
   "customizations": {
     "vscode": {
       "extensions": [
@@ -20,18 +27,14 @@
         "shellcheck.useWorkspaceRootAsCwd": false,
         // disable needlessly aggressive lints
         "shellcheck.exclude": [
-          "2310" // functions invoked in `if` with `set -e`
+          "2310", // functions invoked in `if` with `set -e`
+          "2312" // invoke command separately to avoid masking return values
         ],
         // run ShellCheck when the editor is saved
         "shellcheck.run": "onSave",
         // supply custom arguments to make the most use of ShellCheck
         "shellcheck.customArgs": [
-          "--shell=bash",
-          "--severity=style",
-          "--extended-analysis=true",
-          "--source-path=SCRIPTDIR",
-          "--external-sources",
-          "--color=auto"
+          "--rcfile=/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_bash/shellcheck.conf"
         ]
       }
     }

src/lang-bash/README.md src/lang-sh/README.mdsrc/lang-bash/README.md renamed to src/lang-sh/README.md

@@ -0,0 +1,26 @@
+#! /bin/sh
+
+set -e -u
+
+FEATURE_SHARE_DIR=/usr/local/share/dev_containers/features/ghcr_io/georglauterbach/lang_bash
+readonly FEATURE_SHARE_DIR
+
+parse_dev_container_options() {
+  log 'info' 'Parsing input from options'
+
+  readonly COPY_LIBBASH="${COPY_LIBBASH:?COPY_LIBBASH not set or null}"
+}
+
+main() {
+  parse_dev_container_options
+
+  cp shellcheck.conf "${FEATURE_SHARE_DIR}"
+
+  if "${COPY_LIBBASH}"; then
+    mkdir --parents /usr/local/lib
+    cp libbash "${FEATURE_SHARE_DIR}"
+    cp libbash /usr/local/lib/
+  fi
+
+  return 0
+}