[BUGFIX] Add missing quote

Author: georgringer

Classes/Controller/NewsController.php

@@ -112,7 +112,7 @@ protected function createDemandObjectFromSettings(
 
         /* @var $demand NewsDemand */
         $demand = GeneralUtility::makeInstance($class, $settings);
-        if (!$demand instanceof NewsDemand) {
+        if (!is_a($class, NewsDemand::class, true)) {
             throw new \UnexpectedValueException(
                 sprintf(
                     'The demand object must be an instance of %s, but %s given!',
@@ -122,6 +122,8 @@ protected function createDemandObjectFromSettings(
                 1423157953
             );
         }
+        /* @var $demand NewsDemand */
+        $demand = GeneralUtility::makeInstance($class, $settings);
 
         $demand->setCategories(GeneralUtility::trimExplode(',', $settings['categories'] ?? '', true));
         $demand->setCategoryConjunction((string)($settings['categoryConjunction'] ?? ''));

Classes/Domain/Repository/AbstractDemandedRepository.php

@@ -89,10 +89,11 @@ public function findDemandedRaw(DemandInterface $demand, $respectEnableFields =
 
         $queryBuilder = $queryParser->convertQueryToDoctrineQueryBuilder($query);
         $queryParameters = $queryBuilder->getParameters();
+        $connection = $queryBuilder->getConnection();
         $params = [];
         foreach ($queryParameters as $key => $value) {
             // prefix array keys with ':'
-            $params[':' . $key] = "'" . $value . "'";
+            $params[':' . $key] = $connection->quote($value);
             unset($params[$key]);
         }
         // replace placeholders with real values

Classes/Domain/Repository/NewsRepository.php

@@ -353,6 +353,8 @@ public function findByUid($uid, $respectEnableFields = true): ?News
      */
     public function countByDate(DemandInterface $demand): array
     {
+        $connection = GeneralUtility::makeInstance(ConnectionPool::class)
+            ->getConnectionForTable('tx_news_domain_model_news');
         $data = [];
         $sql = $this->findDemandedRaw($demand);
 
@@ -361,10 +363,8 @@ public function countByDate(DemandInterface $demand): array
 
         // Get the month/year into the result
         $field = $demand->getDateField();
-        $field = empty($field) ? 'datetime' : $field;
+        $field = $connection->quoteIdentifier(empty($field) ? 'datetime' : $field);
 
-        $connection = GeneralUtility::makeInstance(ConnectionPool::class)
-            ->getConnectionForTable('tx_news_domain_model_news');
         $isPostgres = $connection->getDatabasePlatform() instanceof PostgreSQLPlatform;
         $isSqlite = $connection->getDatabasePlatform() instanceof SQLitePlatform;
         if ($isPostgres) {

Documentation/Misc/Changelog/12-3-2.rst

@@ -0,0 +1,17 @@
+12.3.2 - 18th May 2026
+======================
+
+Regular release, please read the following notes carefully.
+
+.. contents::
+        :local:
+        :depth: 3
+
+
+All Changes
+-----------
+This is a list of all changes in this release: ::
+
+    2026-05-18 [BUGFIX] Add missing quote
+
+This list has been created by using `git log $(git describe --tags --abbrev=0)..HEAD --abbrev-commit --pretty='%ad %s (Commit %h by %an)' --date=short`.

Documentation/Misc/Changelog/13-0-2.rst

@@ -0,0 +1,17 @@
+13.0.2 - 18th May 2026
+======================
+
+Regular release, please read the following notes carefully.
+
+.. contents::
+        :local:
+        :depth: 3
+
+
+All Changes
+-----------
+This is a list of all changes in this release: ::
+
+    2026-05-18 [BUGFIX] Add missing quote
+
+This list has been created by using `git log $(git describe --tags --abbrev=0)..HEAD --abbrev-commit --pretty='%ad %s (Commit %h by %an)' --date=short`.

Documentation/Misc/Changelog/14-0-3.rst

@@ -0,0 +1,17 @@
+14.0.3 - 18th May 2026
+======================
+
+Regular release, please read the following notes carefully.
+
+.. contents::
+        :local:
+        :depth: 3
+
+
+All Changes
+-----------
+This is a list of all changes in this release: ::
+
+    2026-05-18 [BUGFIX] Add missing quote
+
+This list has been created by using `git log $(git describe --tags --abbrev=0)..HEAD --abbrev-commit --pretty='%ad %s (Commit %h by %an)' --date=short`.

Documentation/Misc/Changelog/Index.rst

@@ -17,12 +17,14 @@ List of versions
    :titlesonly:
    :glob:
 
-
+   14-0-3
    14-0-2
    14-0-1
    14-0-0
+   13-0-2
    13-0-1
    13-0-0
+   12-3-2
    12-3-1
    12-3-0
    12-2-0

ext_emconf.php

@@ -7,7 +7,7 @@
     'author' => 'Georg Ringer',
     'author_email' => 'mail@ringer.it',
     'state' => 'stable',
-    'version' => '14.0.2',
+    'version' => '14.0.3',
     'constraints' => [
         'depends' => [
             'php' => '8.2.0-8.5.99',