Missing datas in SLD file after conversion : Mapbox to SLD

[stoffy28]

Look at this sample Mapbox file :

{
  "version": 8,
  "name": "Basic",
  "metadata": {
    "mapbox:autocomposite": false,
    "mapbox:type": "template",
    "maputnik:renderer": "mbgljs",
    "openmaptiles:version": "3.x",
    "openmaptiles:mapbox:owner": "openmaptiles",
    "openmaptiles:mapbox:source:url": "mapbox://openmaptiles.4qljc88t"
  },
  "sources": {
    "openmaptiles": {
      "type": "vector",
      "url": "https://api.maptiler.com/tiles/v3-openmaptiles/tiles.json?key=get_your_own_OpIi9ZULNHzrESv6T2vL"
    }
  },
  "sprite": "https://openmaptiles.github.io/maptiler-basic-gl-style/sprite",
  "glyphs": "https://api.maptiler.com/fonts/{fontstack}/{range}.pbf?key=get_your_own_OpIi9ZULNHzrESv6T2vL",
  "layers": [
    {
      "id": "landuse-residential",
      "type": "fill",
      "source": "openmaptiles",
      "source-layer": "landuse",
      "filter": [
        "all",
        ["==", "$type", "Polygon"],
        ["in", "class", "residential", "suburb", "neighbourhood"]
      ],
      "layout": {"visibility": "visible"},
      "paint": {"fill-color": "hsl(47, 13%, 86%)", "fill-opacity": 0.7}
    },
    {
      "id": "landcover_grass",
      "type": "fill",
      "source": "openmaptiles",
      "source-layer": "landcover",
      "filter": ["==", "class", "grass"],
      "paint": {"fill-color": "hsl(82, 46%, 72%)", "fill-opacity": 0.45}
    },
    {
      "id": "landcover_wood",
      "type": "fill",
      "source": "openmaptiles",
      "source-layer": "landcover",
      "filter": ["==", "class", "wood"],
      "paint": {
        "fill-color": "hsl(82, 46%, 72%)",
        "fill-opacity": {"base": 1, "stops": [[8, 0.6], [22, 1]]}
      }
    }
  ],
  "id": "basic"
}

I convert it to SLD with geostyler-cli release 5.0.4.

After conversion to SLD, here is the output file :

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<StyledLayerDescriptor version="1.0.0" xsi:schemaLocation="http://www.opengis.net/sld StyledLayerDescriptor.xsd" xmlns="http://www.opengis.net/sld" xmlns:ogc="http://www.opengis.net/ogc" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:se="http://www.opengis.net/se">
	<NamedLayer>
		<Name>Basic</Name>
		<UserStyle>
			<Name>Basic</Name>
			<Title>Basic</Title>
			<FeatureTypeStyle>
				<Rule>
					<Name>landuse-residential</Name>
					<Filter xmlns="http://www.opengis.net/ogc"/>
				</Rule>
				<Rule>
					<Name>landcover_grass</Name>
					<Filter xmlns="http://www.opengis.net/ogc">
						<PropertyIsEqualTo>
							<PropertyName>class</PropertyName>
							<Literal>grass</Literal>
						</PropertyIsEqualTo>
					</Filter>
				</Rule>
				<Rule>
					<Name>landcover_wood</Name>
					<Filter xmlns="http://www.opengis.net/ogc">
						<PropertyIsEqualTo>
							<PropertyName>class</PropertyName>
							<Literal>wood</Literal>
						</PropertyIsEqualTo>
					</Filter>
				</Rule>
			</FeatureTypeStyle>
		</UserStyle>
	</NamedLayer>
</StyledLayerDescriptor>

All datas like 'filter', 'layout', 'paint' are gone.

[jansule]

This is the output from following command (with mapbox.json containing your style):

geostyler-cli -s mapbox -t geostyler mapbox.json

{
  "name": "Basic",
  "rules": [
    {
      "filter": [
        "&&",
        [
          "==",
          "$type",
          "Polygon"
        ],
        [
          "in",
          "class",
          "residential",
          "suburb",
          "neighbourhood"
        ]
      ],
      "name": "landuse-residential",
      "symbolizers": [
        {
          "kind": "Fill",
          "visibility": true,
          "opacity": 0.7
        }
      ]
    },
    {
      "filter": [
        "==",
        "class",
        "grass"
      ],
      "name": "landcover_grass",
      "symbolizers": [
        {
          "kind": "Fill",
          "opacity": 0.45
        }
      ]
    },
    {
      "filter": [
        "==",
        "class",
        "wood"
      ],
      "name": "landcover_wood",
      "symbolizers": [
        {
          "kind": "Fill",
          "opacity": {
            "base": 1,
            "stops": [
              [
                8,
                0.6
              ],
              [
                22,
                1
              ]
            ]
          }
        }
      ]
    }
  ],
  "metadata": {
    "mapbox:ref": {
      "sources": {
        "openmaptiles": {
          "type": "vector",
          "url": "https://api.maptiler.com/tiles/v3-openmaptiles/tiles.json?key=get_your_own_OpIi9ZULNHzrESv6T2vL"
        }
      },
      "sourceMapping": {
        "openmaptiles": [
          0,
          1,
          2
        ]
      },
      "sourceLayerMapping": {
        "landuse": [
          0
        ],
        "landcover": [
          1,
          2
        ]
      }
    }
  }
}

It is easier to get to the root of the problem, when doing one conversion after the other, so we can see if it is a mapbox-parser problem or a sld-parser problem (or both).

So in this case it looks like some parameters are being swallowed by mapbox-parser, e.g. the fill property probably due to it not supporting hsl values. Others are being swallowed by sld-parser.

Could you take a look at the different parts and create issues in the respective repositories?

[stoffy28]

I'm not sure to understand what repositories you're talking about ... ?
I know only one repo, it's "geostyler-cli" ?

[jansule]

GeoStyler consists of multiple repositories, see https://github.com/orgs/geostyler/repositories

Above, I'm explicitly talking about

• https://github.com/geostyler/geostyler-mapbox-parser
• https://github.com/geostyler/geostyler-sld-parser

[stoffy28]

ok I see
Well, mapbox parser is coded in TypeScript, I'm not competent for this language.
Not sure I'll be of much help on this one
Should I compile it ?

[jansule]

The geostyler-cli is using the different parsers under the hood, when converting the formats: when converting from mapbox to geostyler, the geostyler-mapbox-parser is used, when converting from geostyler to sld, the geostyler-sld-parser is used, etc.

So for documenting the beforementioned issues, you can still use the geostyler-cli, but only convert from one format to/from geostyler and then create an issue in the respective repository, for everything that is not working.

[stoffy28]

OK, it seems that the issue comes from geostyler-sld-parser.