Merge pull request #24 from geotribu/fix/clean-username

fix(nickname): make `getuser` compliant with qchat

Author: gounux

qchat/constants.py

@@ -1,4 +1,5 @@
 QCHAT_NICKNAME_MINLENGTH: int = 3
+QCHAT_NICKNAME_MAXLENGTH_DEFAULT: int = 32
 ADMIN_MESSAGES_NICKNAME: str = "admin"
 ADMIN_MESSAGES_AVATAR: str = "mIconWarning.svg"
 ERROR_MESSAGES_COLOR: str = "#ff0000"

qchat/gui/dck_qchat.py

@@ -41,6 +41,7 @@
     QCHAT_MESSAGE_TYPE_NEWCOMER,
     QCHAT_MESSAGE_TYPE_POSITION,
     QCHAT_MESSAGE_TYPE_TEXT,
+    QCHAT_NICKNAME_MAXLENGTH_DEFAULT,
     QCHAT_NICKNAME_MINLENGTH,
 )
 from qchat.gui.qchat_tree_widget_items import (
@@ -252,8 +253,8 @@ def on_widget_opened(self) -> None:
             self.max_author_length = rules["max_author_length"]
         except Exception as exc:
             self.iface.messageBar().pushCritical(self.tr("QChat error"), str(exc))
-            self.min_author_length = 3
-            self.max_author_length = 32
+            self.min_author_length = QCHAT_NICKNAME_MINLENGTH
+            self.max_author_length = QCHAT_NICKNAME_MAXLENGTH_DEFAULT
 
         # clear channel combobox items
         self.cbb_channel.clear()  # delete all items from comboBox

qchat/gui/gui_commons.py

@@ -12,6 +12,7 @@
 
 # alphanumeric
 _alphanum_qreg = QRegularExpression("[a-z-A-Z-0-9-_]+")
+_alphanum_excl = r"[^a-zA-Z0-9-_]"
 QVAL_ALPHANUM = QRegularExpressionValidator(_alphanum_qreg)
 
 # alphanumeric extended

qchat/toolbelt/preferences.py

@@ -2,16 +2,21 @@
 
 """Plugin settings."""
 
+import re
+
 # standard
 from dataclasses import asdict, dataclass, fields
 from getpass import getuser
 
 # PyQGIS
 from qgis.core import QgsSettings
 
-# package
 import qchat.toolbelt.log_handler as log_hdlr
 from qchat.__about__ import __title__, __version__
+
+# package
+from qchat.constants import QCHAT_NICKNAME_MAXLENGTH_DEFAULT
+from qchat.gui.gui_commons import _alphanum_excl
 from qchat.toolbelt.env_var_parser import EnvVarParser
 
 # ############################################################################
@@ -60,7 +65,9 @@ class PlgSettingsStructure:
         f"utm_source=QGIS&utm_medium={__title__}&utm_campaign=plugin_{__version__}"
     )
 
-    nickname: str = getuser()
+    nickname: str = re.sub(_alphanum_excl, "_", getuser())[
+        :QCHAT_NICKNAME_MAXLENGTH_DEFAULT
+    ]
     avatar: str = "mGeoPackage.svg"
 
     instance_uri: str = "https://qchat.geotribu.net"