Skip to content

Commit 8e94574

Browse files
GutsGuts
committed
refactoring(ui): modularize license and compliance widgets
1 parent 7827240 commit 8e94574

File tree

5 files changed

+222
-261
lines changed

5 files changed

+222
-261
lines changed

‎qtribu/gui/form_article.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def initGui(self) -> None:
7575
)
7676

7777
# custom sub-widget
78-
self.wdg_editing_compliance.frm_rdp.hide()
78+
self.wdg_editing_compliance.chb_license_rdp.setEnabled(False)
7979
self.wdg_editing_compliance.chb_transparency.setText(
8080
self.wdg_editing_compliance.chb_transparency.text()
8181
+ self.tr("\n If not, I give some details in the comment area.")

‎qtribu/gui/form_rdp_news.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ def initGui(self) -> None:
108108
)
109109

110110
# custom sub-widget
111-
self.wdg_editing_compliance.frm_articles.hide()
111+
self.wdg_editing_compliance.lbl_license_article.setEnabled(False)
112+
self.wdg_editing_compliance.cbb_license_article.setEnabled(False)
112113
self.wdg_editing_compliance.chb_transparency.setText(
113114
self.wdg_editing_compliance.chb_transparency.text()
114115
+ self.tr("\n If not, I give some details in the comment area.")

‎qtribu/gui/wdg_editing_compliance.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ def __init__(self, parent: Optional[QWidget] = None) -> None:
3232

3333
def initGui(self) -> None:
3434
"""Initialize GUI elements."""
35-
# populate license combo box
35+
# articles: license combo box
36+
self.lbl_license_article.setBuddy(self.cbb_license_article)
3637
self.cbb_license_article.addItems(
3738
[
3839
"Creative Commons International BY-NC-SA 4.0",

‎qtribu/gui/wdg_editing_compliance.ui‎

Lines changed: 64 additions & 212 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<rect>
77
<x>0</x>
88
<y>0</y>
9-
<width>870</width>
10-
<height>161</height>
9+
<width>806</width>
10+
<height>159</height>
1111
</rect>
1212
</property>
1313
<property name="windowTitle">
@@ -43,59 +43,6 @@
4343
</property>
4444
</widget>
4545
</item>
46-
<item row="0" column="0" rowspan="2" colspan="2">
47-
<widget class="QFrame" name="frm_transparency">
48-
<property name="frameShape">
49-
<enum>QFrame::NoFrame</enum>
50-
</property>
51-
<property name="frameShadow">
52-
<enum>QFrame::Plain</enum>
53-
</property>
54-
<property name="lineWidth">
55-
<number>0</number>
56-
</property>
57-
<layout class="QFormLayout" name="formLayout_3">
58-
<property name="leftMargin">
59-
<number>1</number>
60-
</property>
61-
<property name="topMargin">
62-
<number>1</number>
63-
</property>
64-
<property name="rightMargin">
65-
<number>1</number>
66-
</property>
67-
<property name="bottomMargin">
68-
<number>1</number>
69-
</property>
70-
<item row="0" column="0">
71-
<widget class="QLabel" name="lbl_transparency">
72-
<property name="sizePolicy">
73-
<sizepolicy hsizetype="Fixed" vsizetype="Preferred">
74-
<horstretch>0</horstretch>
75-
<verstretch>0</verstretch>
76-
</sizepolicy>
77-
</property>
78-
<property name="text">
79-
<string>Transparency:</string>
80-
</property>
81-
</widget>
82-
</item>
83-
<item row="0" column="1">
84-
<widget class="QCheckBox" name="chb_transparency">
85-
<property name="sizePolicy">
86-
<sizepolicy hsizetype="Minimum" vsizetype="Preferred">
87-
<horstretch>0</horstretch>
88-
<verstretch>0</verstretch>
89-
</sizepolicy>
90-
</property>
91-
<property name="text">
92-
<string>I'm sure that the content fit with editing rules.</string>
93-
</property>
94-
</widget>
95-
</item>
96-
</layout>
97-
</widget>
98-
</item>
9946
<item row="0" column="2" rowspan="4">
10047
<widget class="QPushButton" name="btn_open_editing_policy">
10148
<property name="sizePolicy">
@@ -118,115 +65,18 @@
11865
</property>
11966
</widget>
12067
</item>
121-
<item row="8" column="0" colspan="2">
122-
<widget class="QFrame" name="frm_articles">
123-
<property name="frameShape">
124-
<enum>QFrame::NoFrame</enum>
125-
</property>
126-
<property name="frameShadow">
127-
<enum>QFrame::Plain</enum>
128-
</property>
129-
<property name="lineWidth">
130-
<number>0</number>
131-
</property>
132-
<layout class="QFormLayout" name="formLayout_2">
133-
<property name="leftMargin">
134-
<number>1</number>
135-
</property>
136-
<property name="topMargin">
137-
<number>1</number>
138-
</property>
139-
<property name="rightMargin">
140-
<number>1</number>
141-
</property>
142-
<property name="bottomMargin">
143-
<number>1</number>
144-
</property>
145-
<item row="0" column="0">
146-
<widget class="QLabel" name="lbl_license_article">
147-
<property name="font">
148-
<font>
149-
<pointsize>11</pointsize>
150-
<weight>50</weight>
151-
<bold>false</bold>
152-
</font>
153-
</property>
154-
<property name="text">
155-
<string>Preferred license for my articles:</string>
156-
</property>
157-
</widget>
158-
</item>
159-
<item row="0" column="1">
160-
<widget class="QComboBox" name="cbb_license_article">
161-
<property name="sizePolicy">
162-
<sizepolicy hsizetype="Preferred" vsizetype="Preferred">
163-
<horstretch>0</horstretch>
164-
<verstretch>0</verstretch>
165-
</sizepolicy>
166-
</property>
167-
<property name="frame">
168-
<bool>false</bool>
169-
</property>
170-
</widget>
171-
</item>
172-
</layout>
173-
</widget>
174-
</item>
175-
<item row="6" column="0" rowspan="2" colspan="2">
176-
<widget class="QFrame" name="frm_rdp">
177-
<property name="frameShape">
178-
<enum>QFrame::NoFrame</enum>
179-
</property>
180-
<property name="frameShadow">
181-
<enum>QFrame::Plain</enum>
68+
<item row="7" column="0">
69+
<widget class="QLabel" name="lbl_license_article">
70+
<property name="font">
71+
<font>
72+
<pointsize>11</pointsize>
73+
<weight>50</weight>
74+
<bold>false</bold>
75+
</font>
18276
</property>
183-
<property name="lineWidth">
184-
<number>0</number>
77+
<property name="text">
78+
<string>Preferred license for my articles:</string>
18579
</property>
186-
<layout class="QFormLayout" name="formLayout">
187-
<property name="leftMargin">
188-
<number>1</number>
189-
</property>
190-
<property name="topMargin">
191-
<number>1</number>
192-
</property>
193-
<property name="rightMargin">
194-
<number>1</number>
195-
</property>
196-
<property name="bottomMargin">
197-
<number>1</number>
198-
</property>
199-
<item row="0" column="0">
200-
<widget class="QLabel" name="lbl_license_rdp">
201-
<property name="font">
202-
<font>
203-
<pointsize>11</pointsize>
204-
<weight>50</weight>
205-
<bold>false</bold>
206-
</font>
207-
</property>
208-
<property name="text">
209-
<string>License for my RDP news:</string>
210-
</property>
211-
</widget>
212-
</item>
213-
<item row="0" column="1">
214-
<widget class="QCheckBox" name="chb_license_rdp">
215-
<property name="sizePolicy">
216-
<sizepolicy hsizetype="Preferred" vsizetype="Preferred">
217-
<horstretch>0</horstretch>
218-
<verstretch>0</verstretch>
219-
</sizepolicy>
220-
</property>
221-
<property name="text">
222-
<string>I accept that my contributed news are published under the CC BY-NC-SA 4.0</string>
223-
</property>
224-
<property name="tristate">
225-
<bool>false</bool>
226-
</property>
227-
</widget>
228-
</item>
229-
</layout>
23080
</widget>
23181
</item>
23282
<item row="6" column="2" rowspan="3">
@@ -252,60 +102,62 @@ available licenses</string>
252102
</property>
253103
</widget>
254104
</item>
105+
<item row="7" column="1">
106+
<widget class="QComboBox" name="cbb_license_article">
107+
<property name="sizePolicy">
108+
<sizepolicy hsizetype="Preferred" vsizetype="Preferred">
109+
<horstretch>0</horstretch>
110+
<verstretch>0</verstretch>
111+
</sizepolicy>
112+
</property>
113+
<property name="frame">
114+
<bool>false</bool>
115+
</property>
116+
</widget>
117+
</item>
118+
<item row="6" column="0" colspan="2">
119+
<widget class="QCheckBox" name="chb_license_rdp">
120+
<property name="sizePolicy">
121+
<sizepolicy hsizetype="Preferred" vsizetype="Preferred">
122+
<horstretch>0</horstretch>
123+
<verstretch>0</verstretch>
124+
</sizepolicy>
125+
</property>
126+
<property name="text">
127+
<string>License for my RDP news: I accept that my news are published under the CC BY-NC-SA 4.0</string>
128+
</property>
129+
<property name="tristate">
130+
<bool>false</bool>
131+
</property>
132+
</widget>
133+
</item>
255134
<item row="2" column="0" colspan="2">
256-
<widget class="QFrame" name="frm_genai">
257-
<property name="frameShape">
258-
<enum>QFrame::NoFrame</enum>
135+
<widget class="QCheckBox" name="chb_genai_editing_policy">
136+
<property name="sizePolicy">
137+
<sizepolicy hsizetype="Fixed" vsizetype="Preferred">
138+
<horstretch>0</horstretch>
139+
<verstretch>0</verstretch>
140+
</sizepolicy>
259141
</property>
260-
<property name="frameShadow">
261-
<enum>QFrame::Plain</enum>
142+
<property name="toolTip">
143+
<string>Contributions must be original and not copied and pasted from a prompt, as described in the editing charter.</string>
262144
</property>
263-
<property name="lineWidth">
264-
<number>0</number>
145+
<property name="text">
146+
<string>GenAI editing policy: I'm aware of the guidelines regarding the use of GenAI for contributions.</string>
147+
</property>
148+
</widget>
149+
</item>
150+
<item row="1" column="0" colspan="2">
151+
<widget class="QCheckBox" name="chb_transparency">
152+
<property name="sizePolicy">
153+
<sizepolicy hsizetype="Minimum" vsizetype="Preferred">
154+
<horstretch>0</horstretch>
155+
<verstretch>0</verstretch>
156+
</sizepolicy>
157+
</property>
158+
<property name="text">
159+
<string>Transparency: I'm sure that the content fit with editing rules.</string>
265160
</property>
266-
<layout class="QFormLayout" name="formLayout_4">
267-
<property name="leftMargin">
268-
<number>1</number>
269-
</property>
270-
<property name="topMargin">
271-
<number>1</number>
272-
</property>
273-
<property name="rightMargin">
274-
<number>1</number>
275-
</property>
276-
<property name="bottomMargin">
277-
<number>1</number>
278-
</property>
279-
<item row="0" column="0">
280-
<widget class="QLabel" name="lbl_genai_editing_policy">
281-
<property name="sizePolicy">
282-
<sizepolicy hsizetype="Minimum" vsizetype="Minimum">
283-
<horstretch>0</horstretch>
284-
<verstretch>0</verstretch>
285-
</sizepolicy>
286-
</property>
287-
<property name="text">
288-
<string>GenAI editing policy:</string>
289-
</property>
290-
</widget>
291-
</item>
292-
<item row="0" column="1">
293-
<widget class="QCheckBox" name="chb_genai_editing_policy">
294-
<property name="sizePolicy">
295-
<sizepolicy hsizetype="Fixed" vsizetype="Preferred">
296-
<horstretch>0</horstretch>
297-
<verstretch>0</verstretch>
298-
</sizepolicy>
299-
</property>
300-
<property name="toolTip">
301-
<string>Contributions must be original and not copied and pasted from a prompt, as described in the editing charter.</string>
302-
</property>
303-
<property name="text">
304-
<string>I'm aware of the guidelines regarding the use of GenAI for contributions.</string>
305-
</property>
306-
</widget>
307-
</item>
308-
</layout>
309161
</widget>
310162
</item>
311163
</layout>

0 commit comments

Comments
 (0)