fix(tests): add flaky to After Uploading large presentation, apply some review suggestions

Author: germanocaumo

bigbluebutton-html5/imports/ui/components/breakout-room/breakout-observer/component.tsx

@@ -109,7 +109,7 @@ const BreakoutRoomsAppObserver = () => {
       pinApp(BREAKOUTS_APP_KEY);
     }
     setBreakoutsCreationIsOpen(false);
-  }, [hasBreakoutRoom]);
+  }, [hasBreakoutRoom, isBreakoutMeeting, isModerator, isBreakoutRoomsEnabled]);
 
   useEffect(() => {
     setNotificationApp(BREAKOUTS_APP_KEY, isNotAssigned && !hasOpenedPanel);
@@ -162,6 +162,7 @@ const BreakoutRoomsAppObserver = () => {
     isModerator,
     isBreakoutMeeting,
     breakoutLabel,
+    isBreakoutRoomsEnabled,
   ]);
 
   useEffect(() => {

bigbluebutton-tests/playwright/chat/chat.js

@@ -185,7 +185,7 @@ class Chat extends MultiUsers {
     await openPublicChat(this.modPage);
     if (!emojiPickerEnabled) {
       await this.modPage.hasElement(e.chatBox, 'should display the chat box element on the public chat');
-      return this.modPage.wasRemoved(e.emojiPickerButton, 'should not display the emoji picker button on the public chat'); t
+      return this.modPage.wasRemoved(e.emojiPickerButton, 'should not display the emoji picker button on the public chat');
     }
     await this.modPage.waitAndClick(e.emojiPickerButton);
     await this.modPage.getByLabelAndClick(e.thumbsUpEmoji);

bigbluebutton-tests/playwright/core/elements.js

@@ -260,8 +260,6 @@ exports.hasUnreadMessages = 'div[data-test="unreadMessages"]';
 exports.userJoinPushAlerts = 'input[data-test="userJoinPopupAlerts"]';
 exports.toastContainer = 'div[data-test="toastContainer"]';
 exports.presentationStatusInfo = 'span[data-test="presentationStatusInfo"]';
-exports.confirmRecordingButton = 'button[data-test="confirmRecordingButton"]';
-exports.cancelRecordingButton = 'button[data-test="cancelRecordingButton"]';
 exports.processingPresentationItem = 'span[data-test="processingPresentationItem"]';
 exports.uploadDoneIcon = 'i[data-test="uploadDoneIcon"]';
 exports.noButton = 'button[aria-label="No"]';

bigbluebutton-tests/playwright/parameters/parameters.spec.js

@@ -641,7 +641,7 @@ test.describe.parallel('Custom Parameters', { tag: '@ci' }, () => {
       await customParam.hidePresentationOnJoinReturnFromBreakouts();
     });
 
-    test('After Uploading large presentation', async ({ browser, context, page }, testInfo) => {
+    test('After Uploading large presentation', { tag: '@flaky-3.1' }, async ({ browser, context, page }, testInfo) => {
       const customParam = new CustomParameters(browser, context);
       await customParam.initModPage(page, true, { joinParameter: c.hidePresentationOnJoin, testInfo });
       await customParam.initUserPage(true, context, { useModMeetingId: true, joinParameter: c.hidePresentationOnJoin, testInfo });

bigbluebutton-tests/playwright/recording/recording.js

@@ -79,8 +79,8 @@ class Recording extends MultiUsers {
       const text = await recordingIndicatorButton.textContent();
       const match = text.match(/(\d+):(\d+)/);
       expect(match, 'should find time pattern in recording button text').not.toBeNull();
-      const [_, minutes, seconds] = match;
-      const totalSeconds = parseInt(minutes) * 60 + parseInt(seconds);
+      const [, minutes, seconds] = match;
+      const totalSeconds = Number.parseInt(minutes) * 60 + Number.parseInt(seconds);
       expect(totalSeconds).toBeGreaterThan(5);
     }, 'should display more than 5 seconds on the recording button counter').toPass({ timeout: ELEMENT_WAIT_LONGER_TIME });
     await this.modPage.waitAndClick(e.leaveMeetingDropdown);