fix(nip47): omit empty fields in get_info response for nwc rust crate (#1750)

* fix(nip47): omit empty fields in get_info response for Rust client compatibility

* fix(nip47): use nullable pointers in get_info response for rust client compatibility

* fix: remove omitempty from pointer fields

Author: krrish-sehgal

nip47/controllers/get_info_controller.go

@@ -13,16 +13,16 @@ import (
 )
 
 type getInfoResponse struct {
-	Alias            string      `json:"alias"`
-	Color            string      `json:"color"`
-	Pubkey           string      `json:"pubkey"`
-	Network          string      `json:"network"`
-	BlockHeight      uint32      `json:"block_height"`
-	BlockHash        string      `json:"block_hash"`
+	Alias            *string     `json:"alias"`
+	Color            *string     `json:"color"`
+	Pubkey           *string     `json:"pubkey"`
+	Network          *string     `json:"network"`
+	BlockHeight      *uint32     `json:"block_height"`
+	BlockHash        *string     `json:"block_hash"`
 	Methods          []string    `json:"methods"`
 	Notifications    []string    `json:"notifications"`
 	Metadata         interface{} `json:"metadata,omitempty"`
-	LightningAddress string      `json:"lud16"`
+	LightningAddress string      `json:"lud16,omitempty"`
 }
 
 func (controller *nip47Controller) HandleGetInfoEvent(ctx context.Context, nip47Request *models.Request, requestEventId uint, app *db.App, publishResponse publishFunc) {
@@ -64,12 +64,12 @@ func (controller *nip47Controller) HandleGetInfoEvent(ctx context.Context, nip47
 			network = "mainnet"
 		}
 
-		responsePayload.Alias = info.Alias
-		responsePayload.Color = info.Color
-		responsePayload.Pubkey = info.Pubkey
-		responsePayload.Network = network
-		responsePayload.BlockHeight = info.BlockHeight
-		responsePayload.BlockHash = info.BlockHash
+		responsePayload.Alias = &info.Alias
+		responsePayload.Color = &info.Color
+		responsePayload.Pubkey = &info.Pubkey
+		responsePayload.Network = &network
+		responsePayload.BlockHeight = &info.BlockHeight
+		responsePayload.BlockHash = &info.BlockHash
 
 		if app != nil {
 			metadata := map[string]interface{}{}

nip47/controllers/get_info_controller_test.go

@@ -60,12 +60,12 @@ func TestHandleGetInfoEvent_NoPermission(t *testing.T) {
 
 	assert.Nil(t, publishedResponse.Error)
 	nodeInfo := publishedResponse.Result.(*getInfoResponse)
-	assert.Empty(t, nodeInfo.Alias)
-	assert.Empty(t, nodeInfo.Color)
-	assert.Empty(t, nodeInfo.Pubkey)
-	assert.Empty(t, nodeInfo.Network)
-	assert.Empty(t, nodeInfo.BlockHeight)
-	assert.Empty(t, nodeInfo.BlockHash)
+	assert.Nil(t, nodeInfo.Alias)
+	assert.Nil(t, nodeInfo.Color)
+	assert.Nil(t, nodeInfo.Pubkey)
+	assert.Nil(t, nodeInfo.Network)
+	assert.Nil(t, nodeInfo.BlockHeight)
+	assert.Nil(t, nodeInfo.BlockHash)
 	// get_info method is always granted, but does not return pubkey
 	assert.Contains(t, nodeInfo.Methods, models.GET_INFO_METHOD)
 	assert.Equal(t, []string{}, nodeInfo.Notifications)
@@ -107,12 +107,12 @@ func TestHandleGetInfoEvent_WithPermission(t *testing.T) {
 
 	assert.Nil(t, publishedResponse.Error)
 	nodeInfo := publishedResponse.Result.(*getInfoResponse)
-	assert.Equal(t, tests.MockNodeInfo.Alias, nodeInfo.Alias)
-	assert.Equal(t, tests.MockNodeInfo.Color, nodeInfo.Color)
-	assert.Equal(t, tests.MockNodeInfo.Pubkey, nodeInfo.Pubkey)
-	assert.Equal(t, tests.MockNodeInfo.Network, nodeInfo.Network)
-	assert.Equal(t, tests.MockNodeInfo.BlockHeight, nodeInfo.BlockHeight)
-	assert.Equal(t, tests.MockNodeInfo.BlockHash, nodeInfo.BlockHash)
+	assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
+	assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
+	assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
+	assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
+	assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
+	assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
 	assert.Contains(t, nodeInfo.Methods, "get_info")
 	assert.Equal(t, []string{}, nodeInfo.Notifications)
 }
@@ -157,12 +157,12 @@ func TestHandleGetInfoEvent_WithMetadata(t *testing.T) {
 
 	assert.Nil(t, publishedResponse.Error)
 	nodeInfo := publishedResponse.Result.(*getInfoResponse)
-	assert.Equal(t, tests.MockNodeInfo.Alias, nodeInfo.Alias)
-	assert.Equal(t, tests.MockNodeInfo.Color, nodeInfo.Color)
-	assert.Equal(t, tests.MockNodeInfo.Pubkey, nodeInfo.Pubkey)
-	assert.Equal(t, tests.MockNodeInfo.Network, nodeInfo.Network)
-	assert.Equal(t, tests.MockNodeInfo.BlockHeight, nodeInfo.BlockHeight)
-	assert.Equal(t, tests.MockNodeInfo.BlockHash, nodeInfo.BlockHash)
+	assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
+	assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
+	assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
+	assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
+	assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
+	assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
 	assert.Contains(t, nodeInfo.Methods, "get_info")
 	assert.Equal(t, []string{}, nodeInfo.Notifications)
 
@@ -214,12 +214,12 @@ func TestHandleGetInfoEvent_WithNotifications(t *testing.T) {
 
 	assert.Nil(t, publishedResponse.Error)
 	nodeInfo := publishedResponse.Result.(*getInfoResponse)
-	assert.Equal(t, tests.MockNodeInfo.Alias, nodeInfo.Alias)
-	assert.Equal(t, tests.MockNodeInfo.Color, nodeInfo.Color)
-	assert.Equal(t, tests.MockNodeInfo.Pubkey, nodeInfo.Pubkey)
-	assert.Equal(t, tests.MockNodeInfo.Network, nodeInfo.Network)
-	assert.Equal(t, tests.MockNodeInfo.BlockHeight, nodeInfo.BlockHeight)
-	assert.Equal(t, tests.MockNodeInfo.BlockHash, nodeInfo.BlockHash)
+	assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
+	assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
+	assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
+	assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
+	assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
+	assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
 	assert.Contains(t, nodeInfo.Methods, "get_info")
 	assert.Equal(t, []string{"payment_received", "payment_sent"}, nodeInfo.Notifications)
 }