build: remove use of setup-maven plugin

Locking maven version is better done with mvnw but probably not necessary here, better to just use what is available on GHA runner for now, to rely on `setup-java` to configure for us.

Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>

Author: chadlwilson

.github/workflows/release_on_pr.yml

@@ -7,10 +7,6 @@ jobs:
     if: github.event.deployment.environment == 'production'
     runs-on: ubuntu-latest
     env:
-      MAVEN_GPG_SIGN_KEY: '${{ secrets.MAVEN_GPG_SIGN_KEY }}'
-      username: '${{ secrets.maven_deploy_username }}'
-      password: '${{ secrets.maven_deploy_password }}'
-      passphrase: '${{ secrets.gpg_passphrase }}'
       GITHUB_TOKEN: '${{ secrets.GAUGEBOT_GITHUB_TOKEN }}'
       CI: true
 
@@ -21,19 +17,11 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: '21'
-
-      - name: Set up Maven
-        uses: stCarolas/setup-maven@v5
-        with:
-          maven-version: 3.9.9
-
-      - name: Setup maven
-        run: |
-          echo -e "$MAVEN_GPG_SIGN_KEY" | gpg --import --batch -
-          gpg --keyserver hkp://keyserver.ubuntu.com --recv-keys $gpgkey
-          rm -rf $HOME/.m2
-          mkdir -p $HOME/.m2
-          echo -e "<settings>\n<servers>\n<server>\n<id>central</id>\n<username>$username</username>\n<password>$password</password>\n</server>\n</servers>\n</settings>" > $HOME/.m2/settings.xml
+          cache: maven
+          server-id: central
+          server-username: MAVEN_CENTRAL_USERNAME
+          server-password: MAVEN_CENTRAL_PASSWORD
+          gpg-private-key: ${{ secrets.MAVEN_GPG_SIGN_KEY }}
 
       - name: Setup git
         run: |
@@ -67,8 +55,11 @@ jobs:
 
       - name: Deploy on maven central
         run: |
-          mvn -q clean deploy -Dgpg.passphrase=$passphrase
-
+          mvn -B "-Dstyle.color=always" clean deploy
+        env:
+          MAVEN_CENTRAL_USERNAME: ${{ secrets.maven_deploy_username }}
+          MAVEN_CENTRAL_PASSWORD: ${{ secrets.maven_deploy_password }}
+          MAVEN_GPG_PASSPHRASE: ${{ secrets.gpg_passphrase }}
 
       - name: Update metadata in gauge-repository
         run: |

.github/workflows/tests.yml

@@ -25,14 +25,10 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: ${{ matrix.java_version }}
-
-      - name: Set up Maven
-        uses: stCarolas/setup-maven@v5
-        with:
-          maven-version: 3.9.9
+          cache: maven
 
       - name: Run test
-        run: mvn -q clean test
+        run: mvn -B "-Dstyle.color=always" clean test
 
   functional_tests:
     name: FTs - java ${{ matrix.java_version }} ${{ matrix.os }}
@@ -58,11 +54,7 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: ${{ matrix.java_version }}
-
-      - name: Set up Maven
-        uses: stCarolas/setup-maven@v5
-        with:
-          maven-version: 3.9.9
+          cache: maven
 
       - uses: getgauge/setup-gauge@master
         with:
@@ -75,7 +67,7 @@ jobs:
 
       - name: Install Gauge Java maven package locally
         run: |
-          mvn -q install -DskipTests -"Dgpg.skip" -D"maven.javadoc.skip=true"
+          mvn -B "-Dstyle.color=always" -DskipTests "-Dgpg.skip" "-Dmaven.javadoc.skip=true" install 
 
       - name: Clone gauge-tests
         run: |
@@ -122,11 +114,7 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: ${{ matrix.java_version }}
-
-      - name: Set up Maven
-        uses: stCarolas/setup-maven@v5
-        with:
-          maven-version: 3.9.9
+          cache: maven
 
       - uses: getgauge/setup-gauge@master
         with:

pom.xml

@@ -256,10 +256,7 @@
                             <goal>sign</goal>
                         </goals>
                         <configuration>
-                            <gpgArguments>
-                                <arg>--pinentry-mode</arg>
-                                <arg>loopback</arg>
-                            </gpgArguments>
+                            <bestPractices>true</bestPractices>
                         </configuration>
                     </execution>
                 </executions>