diff --git a/system/src/Grav/Common/Assets/InlineJs.php b/system/src/Grav/Common/Assets/InlineJs.php index bf5837c5cb..76769cb052 100644 --- a/system/src/Grav/Common/Assets/InlineJs.php +++ b/system/src/Grav/Common/Assets/InlineJs.php @@ -26,7 +26,6 @@ public function __construct(array $elements = [], ?string $key = null) { $base_options = [ 'asset_type' => 'js', - 'position' => 'after' ]; $merged_attributes = Utils::arrayMergeRecursiveUnique($base_options, $elements); diff --git a/tests/unit/Grav/Common/AssetsTest.php b/tests/unit/Grav/Common/AssetsTest.php index 57539a6f34..b876b46314 100644 --- a/tests/unit/Grav/Common/AssetsTest.php +++ b/tests/unit/Grav/Common/AssetsTest.php @@ -555,6 +555,28 @@ public function testPriorityOfAssets(): void self::assertSame('' . PHP_EOL . '' . PHP_EOL . '' . PHP_EOL, $css); + + //---------------- + $this->assets->reset(); + $inline1 = "console.log('position 1');"; + $inline2 = "console.log('position 4');"; + $this->assets->addInlineJs($inline1, 100); + $this->assets->add('position2.js', 90); + $this->assets->add('position3.js', 80); + $this->assets->addInlineJs($inline2, 70); + $this->assets->add('position5.js', 60); + + $js = $this->assets->js(); + $expectedLines = [ + '', + '', + '', + '', + '', + ]; + $expected = implode(PHP_EOL, $expectedLines) . PHP_EOL; + self::assertSame($expected, $js); + } public function testPipeline(): void