Responses Object MUST contain at least one response code (#226)

Author: fenollp

openapi3/operation.go

@@ -71,14 +71,12 @@ func (operation *Operation) AddResponse(status int, response *Response) {
 		responses = NewResponses()
 		operation.Responses = responses
 	}
-	if status == 0 {
-		responses["default"] = &ResponseRef{
-			Value: response,
-		}
-	} else {
-		responses[strconv.FormatInt(int64(status), 10)] = &ResponseRef{
-			Value: response,
-		}
+	code := "default"
+	if status != 0 {
+		code = strconv.FormatInt(int64(status), 10)
+	}
+	responses[code] = &ResponseRef{
+		Value: response,
 	}
 }
 

openapi3/response.go

@@ -12,7 +12,9 @@ import (
 type Responses map[string]*ResponseRef
 
 func NewResponses() Responses {
-	return make(Responses, 8)
+	r := make(Responses)
+	r["default"] = &ResponseRef{Value: NewResponse().WithDescription("")}
+	return r
 }
 
 func (responses Responses) Default() *ResponseRef {
@@ -24,6 +26,9 @@ func (responses Responses) Get(status int) *ResponseRef {
 }
 
 func (responses Responses) Validate(c context.Context) error {
+	if len(responses) == 0 {
+		return errors.New("The Responses Object MUST contain at least one response code")
+	}
 	for _, v := range responses {
 		if err := v.Validate(c); err != nil {
 			return err