Preserve all validation errors for allOf

Previously, only the first error would be reported

Author: alexbakker

openapi3/errors.go

@@ -57,3 +57,13 @@ func (meo multiErrorForOneOf) Error() string {
 func (meo multiErrorForOneOf) Unwrap() error {
 	return MultiError(meo)
 }
+
+type multiErrorForAllOf MultiError
+
+func (mea multiErrorForAllOf) Error() string {
+	return spliceErr(" And ", mea)
+}
+
+func (mea multiErrorForAllOf) Unwrap() error {
+	return MultiError(mea)
+}

openapi3/schema.go

@@ -1427,6 +1427,7 @@ func (schema *Schema) visitXOFOperations(settings *schemaValidationSettings, val
 		visitedAnyOf = true
 	}
 
+	validationErrors := multiErrorForAllOf{}
 	for _, item := range schema.AllOf {
 		v := item.Value
 		if v == nil {
@@ -1436,17 +1437,20 @@ func (schema *Schema) visitXOFOperations(settings *schemaValidationSettings, val
 			if settings.failfast {
 				return errSchema, false
 			}
-			return &SchemaError{
-				Value:                 value,
-				Schema:                schema,
-				SchemaField:           "allOf",
-				Reason:                `doesn't match all schemas from "allOf"`,
-				Origin:                err,
-				customizeMessageError: settings.customizeMessageError,
-			}, false
+			validationErrors = append(validationErrors, err)
 		}
 		visitedAllOf = true
 	}
+	if len(validationErrors) > 0 {
+		return &SchemaError{
+			Value:                 value,
+			Schema:                schema,
+			SchemaField:           "allOf",
+			Reason:                `doesn't match all schemas from "allOf"`,
+			Origin:                fmt.Errorf("doesn't match schema due to: %w", validationErrors),
+			customizeMessageError: settings.customizeMessageError,
+		}, false
+	}
 
 	run = !((visitedOneOf || visitedAnyOf || visitedAllOf) && value == nil)
 	return

openapi3filter/issue641_test.go

@@ -69,7 +69,7 @@ paths:
 			name:   "failed allof pattern",
 			spec:   allOfSpec,
 			req:    `/items?test=999999`,
-			errStr: `parameter "test" in query has an error: string doesn't match the regular expression "^[0-9]{1,4}$"`,
+			errStr: `parameter "test" in query has an error: doesn't match schema due to: string doesn't match the regular expression "^[0-9]{1,4}$"`,
 		},
 	}
 

openapi3filter/issue789_test.go

@@ -69,7 +69,7 @@ paths:
 			name:   "failed allof object array",
 			spec:   allOfArraySpec,
 			req:    `/items?test=foo`,
-			errStr: `parameter "test" in query has an error: string doesn't match the regular expression`,
+			errStr: `parameter "test" in query has an error: doesn't match schema due to: string doesn't match the regular expression`,
 		},
 		{
 			name: "success oneof string pattern match",

openapi3filter/validation_error_test.go

@@ -482,13 +482,12 @@ func getValidationTests(t *testing.T) []*validationTest {
 			wantErrSchemaPath:         "/",
 			wantErrSchemaValue:        map[string]string{"name": "Bahama"},
 			wantErrSchemaReason:       `doesn't match all schemas from "allOf"`,
-			wantErrSchemaOriginReason: `property "photoUrls" is missing`,
+			wantErrSchemaOriginReason: `doesn't match schema due to: property "photoUrls" is missing`,
 			wantErrSchemaOriginValue:  map[string]string{"name": "Bahama"},
 			wantErrSchemaOriginPath:   "/photoUrls",
 			wantErrResponse: &ValidationError{
 				Status: http.StatusUnprocessableEntity,
-				Title:  `property "photoUrls" is missing`,
-				Source: &ValidationErrorSource{Pointer: "/photoUrls"},
+				Title:  `doesn't match all schemas from "allOf"`,
 			},
 		},
 		{