openapi3: fix validation of duplicated path templates (#1189)

reuvenharrison · claude · web-flow · commit d29b5c043d31 · 2026-05-20T08:20:54.000+02:00
Co-authored-by: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/openapi3/paths.go b/openapi3/paths.go
@@ -73,7 +73,7 @@ func (paths *Paths) Validate(ctx context.Context, opts ...ValidationOption) erro
 			// identical findings without new information.
 			continue
 		}
-		normalizedPaths[path] = path
+		normalizedPaths[normalizedPath] = path
 
 		var commonParams []string
 		for _, parameterRef := range pathItem.Parameters {
diff --git a/openapi3/testdata/apis_guru_openapi_directory/amazonaws_com_apigateway_2015_07_09_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/amazonaws_com_apigateway_2015_07_09_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/restapis/{restapi_id}/resources/{resource_id}" and "/restapis/{restapi_id}/resources/{parent_id}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/amazonaws_com_backup_2018_11_15_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/amazonaws_com_backup_2018_11_15_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/audit/report-jobs/{reportPlanName}" and "/audit/report-jobs/{reportJobId}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/carbone_io_1_2_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/carbone_io_1_2_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/render/{templateId}" and "/render/{renderId}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/circuitsandbox_net_2_9_235_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/circuitsandbox_net_2_9_235_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/spaces/{spaceId}/participant" and "/spaces/{id}/participant"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/healthcare_gov_1_0_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/healthcare_gov_1_0_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/es/{stateName}{mediaTypeExtension}" and "/es/{pageName}{mediaTypeExtension}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/jellyfin_local_v1_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/jellyfin_local_v1_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/Items/{itemId}/RemoteSearch/Subtitles/{subtitleId}" and "/Items/{itemId}/RemoteSearch/Subtitles/{language}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/magento_com_2_2_10_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/magento_com_2_2_10_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/V1/bundle-products/{sku}/links/{optionId}" and "/V1/bundle-products/{sku}/links/{id}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/reverb_com_3_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/reverb_com_3_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/conversations/{id}/offer" and "/conversations/{conversation_id}/offer"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/signl4_com_v1_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/signl4_com_v1_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/teams/{teamId}/schedules/{scheduleId}" and "/teams/{teamId}/schedules/{dutyId}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/trello_com_1_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/trello_com_1_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/boards/{idBoard}/cards/{idCard}" and "/boards/{idBoard}/cards/{filter}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/visma_net_9_66_02_1023_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/visma_net_9_66_02_1023_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/controller/api/v1/inventory/internal/{inventoryId}" and "/controller/api/v1/inventory/internal/{inventoryID}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/vtex_local_Catalog_API_1_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/vtex_local_Catalog_API_1_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/api/catalog/pvt/subcollection/{subCollectionId}/brand/{categoryId}" and "/api/catalog/pvt/subcollection/{subCollectionId}/brand/{brandId}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/vtex_local_Catalog_API_Seller_Portal_1_0_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/vtex_local_Catalog_API_Seller_Portal_1_0_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/api/catalog-seller-portal/products/{productId}" and "/api/catalog-seller-portal/products/{param}"
diff --git a/openapi3/testdata/apis_guru_openapi_directory/vtex_local_GiftCard_Hub_API_1_0_openapi_yaml__validate b/openapi3/testdata/apis_guru_openapi_directory/vtex_local_GiftCard_Hub_API_1_0_openapi_yaml__validate
@@ -0,0 +1 @@
+invalid paths: conflicting paths "/giftcardproviders/{giftCardProviderId}" and "/giftcardproviders/{giftCardProviderID}"

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func (paths *Paths) Validate(ctx context.Context, opts ...ValidationOption) erro`
`73`	`73`	`// identical findings without new information.`
`74`	`74`	`continue`
`75`	`75`	`}`
`76`		`- normalizedPaths[path] = path`
	`76`	`+ normalizedPaths[normalizedPath] = path`
`77`	`77`
`78`	`78`	`var commonParams []string`
`79`	`79`	`for _, parameterRef := range pathItem.Parameters {`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/restapis/{restapi_id}/resources/{resource_id}" and "/restapis/{restapi_id}/resources/{parent_id}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/audit/report-jobs/{reportPlanName}" and "/audit/report-jobs/{reportJobId}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/render/{templateId}" and "/render/{renderId}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/spaces/{spaceId}/participant" and "/spaces/{id}/participant"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/es/{stateName}{mediaTypeExtension}" and "/es/{pageName}{mediaTypeExtension}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/Items/{itemId}/RemoteSearch/Subtitles/{subtitleId}" and "/Items/{itemId}/RemoteSearch/Subtitles/{language}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/V1/bundle-products/{sku}/links/{optionId}" and "/V1/bundle-products/{sku}/links/{id}"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/conversations/{id}/offer" and "/conversations/{conversation_id}/offer"`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+invalid paths: conflicting paths "/teams/{teamId}/schedules/{scheduleId}" and "/teams/{teamId}/schedules/{dutyId}"`