fix: Fix case sensitivity in content field cleanup #94

Normalize field keys to lowercase when comparing content fields to blueprint fields, ensuring fields with case differences are properly detected and removed. This prevents orphaned fields due to case mismatches and improves data consistency.

Author: afbora

commands/clean/content.php

@@ -9,7 +9,7 @@
 	array|null $ignore = null,
 	string|null $lang = null
 ): void {
-	foreach($collection as $item) {
+	foreach ($collection as $item) {
 		// get all fields in the content file
 		$contentFields = $item->content($lang)->fields();
 
@@ -20,23 +20,32 @@
 			}
 		}
 
-		// get the keys
-		$contentFields = array_keys($contentFields);
+		// get the keys and normalize to lowercase
+		$originalContentKeys = array_keys($contentFields);
+		$contentFieldKeys = array_map('strtolower', $originalContentKeys);
 
-		// get all field keys from blueprint
+		// get all field keys from blueprint and normalize to lowercase
 		$blueprintFields = array_keys($item->blueprint()->fields());
+		$blueprintFieldKeys = array_map('strtolower', $blueprintFields);
 
-		// get all field keys that are in $contentFields but not in $blueprintFields
-		$fieldsToBeDeleted = array_diff($contentFields, $blueprintFields);
+		// get all field keys that are in $contentFieldKeys but not in $blueprintFieldKeys
+		$fieldsToBeDeleted = array_diff($contentFieldKeys, $blueprintFieldKeys);
 
 		// update page only if there are any fields to be deleted
 		if (count($fieldsToBeDeleted) > 0) {
+			// create a mapping: lowercase => original field name
+			$lowercaseToOriginal = array_combine($contentFieldKeys, $originalContentKeys);
 
 			// flip keys and values and set new values to null
-			$data = array_map(fn ($value) => null, array_flip($fieldsToBeDeleted));
+			$data = array_map(
+				fn ($field) => null,
+				array_flip(array_intersect_key($lowercaseToOriginal, array_flip($fieldsToBeDeleted)))
+			);
 
 			// try to update the page with the data
-			$item->update($data, $lang);
+			if (count($data) > 0) {
+				$item->update($data, $lang);
+			}
 		}
 	}
 };