Commit 4125b2e
committed
[kyo-ui] use non-resolving a.test in iframe/img attribute tests
Problem: IframeTest "iframe src attribute" and HtmlRendererTest
"ImgSrc.Absolute renders full URL" embed a real resolvable external
domain (example.com) as a loaded subresource. withUI navigates via
Browser.goto with the default Settle.NetworkIdle barrier, which does not
return until the page load event fires, and the load event waits for the
iframe/img subresource. On a runner whose egress to example.com is
blocked or slow, that subresource connection hangs, so the settle
barrier times out with "settle timeout after NetworkIdle (load event
also never fired)" and the leaf fails. This surfaced on windows-JS while
the identical JS code passed on linux-JS.
Solution: point both subresources at the RFC 6761 reserved a.test TLD,
which never resolves, so the subresource fails DNS immediately, the load
event fires, and the settle barrier returns fast. The sibling leaf
"iframe reactive src updates" already uses a.test and passes on the same
runner. The tests only assert the rendered src attribute string, so the
domain is irrelevant to what they verify.1 parent 645767c commit 4125b2e
2 files changed
Lines changed: 4 additions & 4 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
757 | 757 | | |
758 | 758 | | |
759 | 759 | | |
760 | | - | |
| 760 | + | |
761 | 761 | | |
762 | 762 | | |
763 | 763 | | |
764 | 764 | | |
765 | | - | |
| 765 | + | |
766 | 766 | | |
767 | 767 | | |
768 | 768 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
0 commit comments