smc: keep-alive ShareNotifier + reflect Unbounded in VPN tile

Two new Copilot fixes (+ a third escalation acknowledged in reply):

1. shareProvider was the default (non-annotated) NotifierProvider,
   which is autoDispose in Riverpod 3.x — so navigating away from
   the screen disposed the notifier, re-entry reset state to
   mode=off / active=false even when SmC or Unbounded was still
   running, and the next toggle tried to re-enable an already-
   enabled setting. Added `ref.keepAlive()` at the top of
   build() so the notifier sticks for the process lifetime.
   onDispose stays registered for the explicit teardown paths
   (provider container reset, hot reload) so the event
   subscription + stream controller still get cleaned up.

2. VPN settings tile rendered "Off" when the user had picked
   "Basic mode (Unbounded)" in the disclosure dialog because
   the subtitle was driven solely by peerProxy. Added
   unboundedEnabled to RadianceSettingsState (with a copyWith
   field + equality / hashCode update), wired the fetch +
   setter through radianceSettingsProvider, and the tile now
   reads OR of both to decide whether to show
   share_my_connection_on_tap_to_view.

dart analyze clean on the touched files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: myleshorton

lib/core/models/radiance_settings_state.dart

@@ -13,13 +13,21 @@ class RadianceSettingsState {
   final bool splitTunneling;
   final bool telemetry;
   final bool peerProxy;
+  // Local opt-in for the broflake / Unbounded widget proxy. Separate
+  // from peerProxy because the two are independent toggles — the SmC
+  // disclosure dialog flips just one of them based on the user's
+  // choice ("Basic mode" → unboundedEnabled, "Full mode" → peerProxy).
+  // The VPN settings tile uses BOTH to decide whether to show the
+  // "On — tap to view" subtitle.
+  final bool unboundedEnabled;
 
   const RadianceSettingsState({
     this.blockAds = false,
     this.routingMode = RoutingMode.full,
     this.splitTunneling = false,
     this.telemetry = false,
     this.peerProxy = false,
+    this.unboundedEnabled = false,
   });
 
   RadianceSettingsState copyWith({
@@ -28,13 +36,15 @@ class RadianceSettingsState {
     bool? splitTunneling,
     bool? telemetry,
     bool? peerProxy,
+    bool? unboundedEnabled,
   }) {
     return RadianceSettingsState(
       blockAds: blockAds ?? this.blockAds,
       routingMode: routingMode ?? this.routingMode,
       splitTunneling: splitTunneling ?? this.splitTunneling,
       telemetry: telemetry ?? this.telemetry,
       peerProxy: peerProxy ?? this.peerProxy,
+      unboundedEnabled: unboundedEnabled ?? this.unboundedEnabled,
     );
   }
 
@@ -46,9 +56,16 @@ class RadianceSettingsState {
           routingMode == other.routingMode &&
           splitTunneling == other.splitTunneling &&
           telemetry == other.telemetry &&
-          peerProxy == other.peerProxy;
+          peerProxy == other.peerProxy &&
+          unboundedEnabled == other.unboundedEnabled;
 
   @override
-  int get hashCode =>
-      Object.hash(blockAds, routingMode, splitTunneling, telemetry, peerProxy);
+  int get hashCode => Object.hash(
+        blockAds,
+        routingMode,
+        splitTunneling,
+        telemetry,
+        peerProxy,
+        unboundedEnabled,
+      );
 }

lib/features/home/provider/radiance_settings_providers.dart

@@ -36,12 +36,14 @@ class RadianceSettings extends _$RadianceSettings {
     // Manual port forwarding works on any home WiFi where the user owns
     // the router, so mobile is included rather than desktop-only.
     final peerF = svc.isPeerProxyEnabled();
+    final unboundedF = svc.isUnboundedEnabled();
 
     final blockAds = await blockAdsF;
     final routing = await routingF;
     final telemetry = await telemetryF;
     final split = splitF == null ? null : await splitF;
     final peer = await peerF;
+    final unbounded = await unboundedF;
     if (!ref.mounted) return;
 
     const defaults = RadianceSettingsState();
@@ -56,6 +58,8 @@ class RadianceSettings extends _$RadianceSettings {
           ? defaults.splitTunneling
           : split.fold((_) => defaults.splitTunneling, (v) => v),
       peerProxy: peer.fold((_) => defaults.peerProxy, (v) => v),
+      unboundedEnabled:
+          unbounded.fold((_) => defaults.unboundedEnabled, (v) => v),
     );
   }
 
@@ -126,6 +130,25 @@ class RadianceSettings extends _$RadianceSettings {
       },
     );
   }
+
+  /// Mirror of setPeerProxy for the Unbounded toggle. Returns the
+  /// Either so callers can react to failure (the Unbounded enable
+  /// path in share_my_connection.dart uses this for UI rollback).
+  Future<Either<Failure, Unit>> setUnboundedEnabled(bool value) async {
+    final svc = ref.read(lanternServiceProvider);
+    final result = await svc.setUnboundedEnabled(value);
+    if (!ref.mounted) return result;
+    return result.fold(
+      (err) {
+        appLogger.error('setUnboundedEnabled failed: ${err.error}');
+        return left(err);
+      },
+      (_) {
+        state = state.copyWith(unboundedEnabled: value);
+        return right(unit);
+      },
+    );
+  }
 }
 
 /// Fetches whether user logged in via OAuth from radiance.

lib/features/setting/vpn_setting.dart

@@ -39,6 +39,15 @@ class VPNSetting extends HookConsumerWidget {
     final peerProxy = ref.watch(
       radianceSettingsProvider.select((s) => s.peerProxy),
     );
+    final unboundedEnabled = ref.watch(
+      radianceSettingsProvider.select((s) => s.unboundedEnabled),
+    );
+    // The tile reads "On" when EITHER donor protocol is active —
+    // the disclosure dialog flips peerProxy for "Full mode" and
+    // unboundedEnabled for "Basic mode", and the user shouldn't
+    // see a stale "Off" subtitle just because they picked the
+    // lower-friction Unbounded path.
+    final shareActive = peerProxy || unboundedEnabled;
 
     return ListView(
       padding: const EdgeInsets.all(0),
@@ -128,7 +137,7 @@ class VPNSetting extends HookConsumerWidget {
             child: AppTile(
               label: 'share_my_connection'.i18n,
               subtitle: Text(
-                peerProxy
+                shareActive
                     ? 'share_my_connection_on_tap_to_view'.i18n
                     : 'share_my_connection_subtitle'.i18n,
                 style: textTheme.labelMedium!.copyWith(

lib/features/share_my_connection/share_my_connection.dart

@@ -201,6 +201,19 @@ class ShareNotifier extends Notifier<ShareState> {
 
   @override
   ShareState build() {
+    // Keep the notifier alive for the process lifetime. Without this,
+    // navigating away from the screen disposes the notifier; re-entry
+    // calls build() again and resets state to mode=off / active=false
+    // even when SmC or Unbounded is still actually running on the
+    // backend. The next toggle would then try to re-enable an
+    // already-enabled setting, and the user loses visibility into
+    // the active counter and the granular peer-status phase.
+    //
+    // ref.onDispose stays registered for explicit Stop/Disable paths
+    // (provider container reset, hot reload, etc.) so the event
+    // subscription and stream controller still get cleaned up when
+    // it does actually happen.
+    ref.keepAlive();
     ref.onDispose(() {
       _stopEventSubscription();
       _eventController.close();